fix: handle unmapped task deadlock when upstream tasks are removed#62034
Open
kevinhongzl wants to merge 6 commits intoapache:mainfrom
Open
fix: handle unmapped task deadlock when upstream tasks are removed#62034kevinhongzl wants to merge 6 commits intoapache:mainfrom
kevinhongzl wants to merge 6 commits intoapache:mainfrom
Conversation
kevinhongzl
force-pushed
the
fix-reducing-mapped-task-deadlock
branch
from
034b0e6 to
e80b6b3
Compare
kevinhongzl
force-pushed
the
fix-reducing-mapped-task-deadlock
branch
from
e80b6b3 to
bd38d91
Compare
eladkal
requested review from
ephraimbuddy,
kaxil and
uranusjr
and removed request for
kaxil
Member
|
Do we currently also have a test where neither the upstream nor the downstream is mapped? This would change the behaviour in that case, but the newly added test does not cover it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #48816
related: #26518
(The previous fix went stale. Therefore, I open a new PR with tests completed.)
While the issue of deadlock caused by removing upstream mapped tasks has been addressed in #26518, that PR only handled cases where the downstream tasks were also mapped. This PR addresses the task deadlock occurring on downstream unmapped tasks.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.