fix(UI): show 403 error when unauthorized user reparses DAG by liamkernan · Pull Request #61560 · apache/airflow

liamkernan · 2026-02-06T20:18:36Z

When a Viewer/Author tries to reparse a DAG, the API correctly returns 403 but the UI shows a misleading generic error ("Dag parsing request failed"). This checks the error status code and shows an "Access Denied" toast for 403 responses instead.

Closes #61459

Made with Cursor

bbovenzi · 2026-02-11T20:21:54Z

Can we check the actual API error response to see if we're just presenting the wrong message? It would be better to send and display the correct errors from the API instead of manually creating error messages in the UI

pierrejeambrun

LGTM and working as expected, thanks.

Just one nit.

airflow-core/src/airflow/ui/src/queries/useDagParsing.ts

pierrejeambrun · 2026-02-12T15:56:47Z

Can we check the actual API error response to see if we're just presenting the wrong message? It would be better to send and display the correct errors from the API instead of manually creating error messages in the UI

API just returns {detail: "Forbidden"} on 403. Which is correct, but displaying that raw isn't great for users. (We do that at other places).

We can globally remap the 403 with 'details: Forbidden' to a generic message. "You do not have permission to perform this action". Which will prevent the need from doing a mapping between the front-end while still displaying something a little bit more explicit.

bbovenzi · 2026-02-12T16:33:35Z

Yes lets make a single generic 403 message to use across the UI

pierrejeambrun

Update: I chatted with Brent, we believe a generic handler is better

airflow-core/src/airflow/ui/public/i18n/locales/en/dag.json

airflow-core/src/airflow/ui/src/queries/useDagParsing.ts

eladkal · 2026-03-03T13:52:14Z

@liamkernan can you handle the open comments?

liamkernan · 2026-03-03T16:06:17Z

Finished; let me know if there's anything else I can tweak or improve.

ephraimbuddy · 2026-03-04T08:54:23Z

Moved to 3.1.9 as the PR is not ready yet cc @pierrejeambrun

…e DAG When a Viewer or Author without edit permission tries to reparse a DAG, the API returns 403 but the UI shows a generic "Dag parsing request failed" message. This checks the error status and shows an appropriate "Access Denied" toast instead. Closes apache#61459 Co-authored-by: Cursor <cursoragent@cursor.com>

Move the forbidden toast copy to common translations and route DAG reparse mutation errors through a shared error toaster helper so 403 responses consistently show a reusable access-denied message. Made-with: Cursor

pierrejeambrun

Looking good, just one nit.

airflow-core/src/airflow/ui/src/components/ui/createErrorToaster.ts

pierrejeambrun · 2026-03-11T10:27:26Z

I just pushed the small adjustment, ready to merge :)

boring-cyborg · 2026-03-11T10:27:38Z

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

…AG (#61560) * fix(UI): show permission error when unauthorized user tries to reparse DAG When a Viewer or Author without edit permission tries to reparse a DAG, the API returns 403 but the UI shows a generic "Dag parsing request failed" message. This checks the error status and shows an appropriate "Access Denied" toast instead. Closes #61459 Co-authored-by: Cursor <cursoragent@cursor.com> * Generalize 403 permission toast handling in UI Move the forbidden toast copy to common translations and route DAG reparse mutation errors through a shared error toaster helper so 403 responses consistently show a reusable access-denied message. Made-with: Cursor * Small adjustments --------- (cherry picked from commit f01c69a) Co-authored-by: Liam <liamkernan0@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: pierrejeambrun <pierrejbrun@gmail.com>

github-actions · 2026-03-11T10:29:13Z

Backport successfully created: v3-1-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status	Branch	Result
✅	v3-1-test

…AG (#61560) (#63339) * fix(UI): show permission error when unauthorized user tries to reparse DAG When a Viewer or Author without edit permission tries to reparse a DAG, the API returns 403 but the UI shows a generic "Dag parsing request failed" message. This checks the error status and shows an appropriate "Access Denied" toast instead. Closes #61459 * Generalize 403 permission toast handling in UI Move the forbidden toast copy to common translations and route DAG reparse mutation errors through a shared error toaster helper so 403 responses consistently show a reusable access-denied message. Made-with: Cursor * Small adjustments --------- (cherry picked from commit f01c69a) Co-authored-by: Liam <liamkernan0@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: pierrejeambrun <pierrejbrun@gmail.com>

…1560) * fix(UI): show permission error when unauthorized user tries to reparse DAG When a Viewer or Author without edit permission tries to reparse a DAG, the API returns 403 but the UI shows a generic "Dag parsing request failed" message. This checks the error status and shows an appropriate "Access Denied" toast instead. Closes apache#61459 Co-authored-by: Cursor <cursoragent@cursor.com> * Generalize 403 permission toast handling in UI Move the forbidden toast copy to common translations and route DAG reparse mutation errors through a shared error toaster helper so 403 responses consistently show a reusable access-denied message. Made-with: Cursor * Small adjustments --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: pierrejeambrun <pierrejbrun@gmail.com>

…1560) * fix(UI): show permission error when unauthorized user tries to reparse DAG When a Viewer or Author without edit permission tries to reparse a DAG, the API returns 403 but the UI shows a generic "Dag parsing request failed" message. This checks the error status and shows an appropriate "Access Denied" toast instead. Closes apache#61459 Co-authored-by: Cursor <cursoragent@cursor.com> * Generalize 403 permission toast handling in UI Move the forbidden toast copy to common translations and route DAG reparse mutation errors through a shared error toaster helper so 403 responses consistently show a reusable access-denied message. Made-with: Cursor * Small adjustments --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: pierrejeambrun <pierrejbrun@gmail.com> (cherry picked from commit f01c69a)

liamkernan requested review from bbovenzi, choo121600, guan404ming, pierrejeambrun, ryanahamilton, shubhamraj-git and vatsrahul1001 as code owners February 6, 2026 20:18

boring-cyborg bot added area:translations area:UI Related to UI/UX. For Frontend Developers. translation:default labels Feb 6, 2026

liamkernan mentioned this pull request Feb 6, 2026

When a Viewer/Author tries to reparse a DAG, the UI shows generic failed to reparse error #61459

Closed

2 tasks

pierrejeambrun approved these changes Feb 12, 2026

View reviewed changes

airflow-core/src/airflow/ui/src/queries/useDagParsing.ts Outdated Show resolved Hide resolved

pierrejeambrun added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Feb 12, 2026

pierrejeambrun added this to the Airflow 3.1.8 milestone Feb 12, 2026

pierrejeambrun mentioned this pull request Feb 12, 2026

UI: Show clear permission toast for 403 errors on user actions #61588

Open

pierrejeambrun reviewed Feb 12, 2026

View reviewed changes

airflow-core/src/airflow/ui/public/i18n/locales/en/dag.json Outdated Show resolved Hide resolved

airflow-core/src/airflow/ui/src/queries/useDagParsing.ts Outdated Show resolved Hide resolved

vatsrahul1001 modified the milestones: Airflow 3.1.8, Airflow 3.1.9 Mar 3, 2026

eladkal modified the milestones: Airflow 3.1.9, Airflow 3.1.8 Mar 3, 2026

ephraimbuddy modified the milestones: Airflow 3.1.8, Airflow 3.1.9 Mar 4, 2026

liamkernan and others added 2 commits March 10, 2026 12:27

Generalize 403 permission toast handling in UI

7ec8e9c

Move the forbidden toast copy to common translations and route DAG reparse mutation errors through a shared error toaster helper so 403 responses consistently show a reusable access-denied message. Made-with: Cursor

pierrejeambrun reviewed Mar 10, 2026

View reviewed changes

airflow-core/src/airflow/ui/src/components/ui/createErrorToaster.ts Show resolved Hide resolved

Small adjustments

f9a0aa4

pierrejeambrun force-pushed the fix-reparse-dag-403-error branch from 72f0bdd to f9a0aa4 Compare March 10, 2026 11:42

choo121600 approved these changes Mar 10, 2026

View reviewed changes

pierrejeambrun merged commit f01c69a into apache:main Mar 11, 2026
79 checks passed

Conversation

liamkernan commented Feb 6, 2026

Uh oh!

bbovenzi commented Feb 11, 2026

Uh oh!

pierrejeambrun left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pierrejeambrun commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bbovenzi commented Feb 12, 2026

Uh oh!

pierrejeambrun left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

eladkal commented Mar 3, 2026

Uh oh!

liamkernan commented Mar 3, 2026

Uh oh!

ephraimbuddy commented Mar 4, 2026

Uh oh!

pierrejeambrun left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pierrejeambrun commented Mar 11, 2026

Uh oh!

Uh oh!

boring-cyborg bot commented Mar 11, 2026

Uh oh!

github-actions bot commented Mar 11, 2026

Backport successfully created: v3-1-test

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

pierrejeambrun commented Feb 12, 2026 •

edited

Loading