Use BaseXCom serialize_value when objectstorage_threshold is less than given input #49173
+41
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoghrajesh
reviewed
Apr 14, 2025
providers/common/io/src/airflow/providers/common/io/xcom/backend.py
Outdated
Show resolved
Hide resolved
|
Post update: @vatsrahul1001 
|
vatsrahul1001
approved these changes
Apr 14, 2025
vatsrahul1001
changed the title
amoghrajesh
approved these changes
Apr 14, 2025
| # likely, we need to deserialize it using json.loads | ||
| data = json.loads(base_xcom_deser_result, cls=XComDecoder) | ||
| except (TypeError, ValueError): | ||
| pass |
There was a problem hiding this comment.
Should we re raise this one?
There was a problem hiding this comment.
I think this is fine, this raises error happen only when base_xcom_deser_result is object store path, likely this is string that means we should continue to next below to read from ObjectStore with path. WDYT?
56 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #49159
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.