Bump Serialized DAG to v2 and handle conversion from v1#49020
Merged
ashb merged 13 commits intoapache:mainfrom Apr 14, 2025
Merged
Bump Serialized DAG to v2 and handle conversion from v1#49020ashb merged 13 commits intoapache:mainfrom
ashb merged 13 commits intoapache:mainfrom
Conversation
ashb
reviewed
Apr 10, 2025
ashb
reviewed
Apr 10, 2025
ashb
reviewed
Apr 10, 2025
ashb
reviewed
Apr 10, 2025
2 tasks
- Make it less general purpose. YAGNI (You Ain't Gonna Need it) -- we can add it back in once we know what patterns make sense - Make each conversion function deal with exactly one version, from it's version to the next. That way as the number of versions grow, we don't need to handle all new versions in all old migrations, we can just chaing v1_to_v2 -> v2_to_v3 etc. - Upgrade schedule_interval to a timetable -- it is not complete yet
ashb
requested review from
bbovenzi,
bolkedebruin,
jason810496,
jscheffl,
pierrejeambrun,
rawwar and
ryanahamilton
as code owners
kaxil
reviewed
Apr 14, 2025
kaxil
reviewed
Apr 14, 2025
kaxil
approved these changes
Apr 14, 2025
ashb
changed the title
2 tasks
Member
|
Failing docs build fixed by #49240 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A number of changes have been made to the serialized DAG structure between 2.x and 3.0, and with the addition of DAG versioning in 3.0 we can't use our old approach of simply force-reserializing all DAGs anymore.
So instead we bump the version record (that has been
1since it was first introduced in 1.10.7, even though there were changes) and upgrade from the latest format in Airflow 2.x such that the Webserver will be able to display things for it.The scheduler is not so easy to fix, so we use a proxy of "skip things that haven't been re-processed" yet by making the scheduler ignore DAGs that don't a bundle name set (as all dags processed in 3.0 have this set, even if it is for a local file bundle)