-
Notifications
You must be signed in to change notification settings - Fork 61
feat(layout): test and demo setup #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v5
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @yvonneyx, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the development workflow for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
本次 PR 为 layout 包搭建了测试和演示环境,引入了 Vite 用于本地开发,并配置了 Jest 进行单元测试和快照测试。整体结构清晰,为后续的开发和测试打下了良好基础。
我在代码中发现了一些可以改进的地方,主要集中在:
- 测试工具函数中的一个严重 bug,可能导致
ReferenceError。 - 快照测试工具中可能导致快照不正确的逻辑。
- 演示代码中一些可以增强类型安全性的地方。
具体的修改建议请见下面的评论。
| const dom = ( | ||
| canvas.getContextService().getDomElement() as unknown as SVGElement | ||
| ).cloneNode(true) as SVGElement; | ||
| // @ts-expect-error dom is SVGElement | ||
| gRoot?.append(...(dom.querySelector('#g-root')?.childNodes || [])); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh oh!
There was an error while loading. Please reload this page.