Skip to content

Conversation

@antross
Copy link
Owner

@antross antross commented Jun 29, 2022

Pull request checklist

Make sure you:

For non-trivial changes, please make sure you also:

  • Added/Updated related documentation.
  • Added/Updated related tests.

Short description of the change(s)

Michael Liao and others added 2 commits June 29, 2022 16:38
Also fix sorting of options when multiple reports occur at the
same location.

- - - - - - - - - - - - - - - - - - - -

Close webhintio#5224
@antross antross force-pushed the user/tross/ignore-browsers branch from dd7fa6f to 12ac576 Compare June 29, 2022 22:40
antross added 5 commits June 30, 2022 11:04
Fixes reports by swapping the name and value of the last
prefixed property with the unprefixed version of the property.

- - - - - - - - - - - - - - - - - - - -

Close webhintio#5223
Creates a new "fix" `CodeAction` when `problem.fixes` exists that contains
both an `edit` to communicate the fix to VS Code and a `command` to allow
the language server host to detect when a fix has been applied.

- - - - - - - - - - - - - - - - - - - -

Close webhintio#5227
Lines are 1-based in the JS AST, but columns are 0-based.
We need both to be 1-based in the parse5 HTML AST, this
was already special-cased for the start tag, but needed to be
applied for all column positions.
@antross antross force-pushed the user/tross/ignore-browsers branch from 61c0149 to 962438e Compare June 30, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants