docs(env): document SM_MULTI_TENANT and SM_TENANT_HEADER opt-in - #58
Closed
antosubash wants to merge 1 commit into
Closed
docs(env): document SM_MULTI_TENANT and SM_TENANT_HEADER opt-in#58antosubash wants to merge 1 commit into
antosubash wants to merge 1 commit into
Conversation
Last piece of the DX hardening plan (2026-04-14). The implementation, tests and conventions doc all reference these vars but .env.example never advertised them, so new deployments had no signpost for the opt-in tenancy flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final remaining item from the DX hardening plan (
docs/plans/2026-04-14-dx-hardening.md— Task 8). The multi-tenant code path and its tests already shipped onmain, anddocs/framework-conventions.mdreferences the env vars, but.env.examplenever advertised them — so new deployments had no signpost for the opt-in tenancy flag.DX hardening plan audit
All 11 implementation tasks from the plan were already landed on
mainbefore this branch was created. Verified each on audit:validation.tspages/validation.tsprint_diagnostics→ stderrtest_diagnostics.py:57all_module_bases_register_base+ test attest_base.py:38SM_PROJECT_ROOTenv overridetest_app.py:79,101,106ModuleMetaat discoverytest_discovery.py:168discover_modules(strict=...)wiringapp_builderpassesstrict=not settings.is_developmentview_prefix="/dashboard", landing moved tohost/routes.pyTenantMiddleware.env.examplestubsget_dbskip commit when cleantest_db_logging.py:76docs/framework-conventions.mdREADME.mdVerification
make test-py— 977 passed, 6 deselectedmake lint— ruff / ty / biome / tsc all clean; 300-line cap OKmake doctor— exit 0 (pre-existingSM003warn onFeatureFlags/Browse.tsxis unrelated)Test plan
make lintpasses locallymake test-pypasses locally (977 tests)make doctorexits 0https://claude.ai/code/session_01EJAM5RUi2pcXPeagmVMK27
Generated by Claude Code