fix(hosting): render Inertia error page for browser validation errors (#170) - #181
Merged
Merged
Conversation
) When a browser navigates to a route with an invalid UUID path parameter, FastAPI raises RequestValidationError which was not handled by the framework exception handlers, resulting in raw JSON instead of a styled Inertia error page. Add a RequestValidationError handler that checks the Accept header: - Browser requests (text/html) get a friendly 422 Inertia error page - API/JSON clients get the standard validation detail response
Deploying simple-module-python with
|
| Latest commit: |
ab4b8aa
|
| Status: | ⚡️ Build in progress... |
RequestValidationError.errors() can contain non-JSON-serializable objects (e.g., ValueError instances in the ctx field). Use FastAPI's jsonable_encoder to safely serialize the error details in the JSON response path of request_validation_error_handler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RequestValidationErrorhandler that checks theAcceptheadertext/html) get a styled Inertia 422 error page instead of raw JSONFixes #170
Test plan
curl -H "Accept: text/html" http://localhost:8000/gis/app/datasets/not-a-uuidreturns styled error pagecurl http://localhost:8000/gis/app/datasets/not-a-uuidreturns JSON validation errors