fix(dashboard): correct heading hierarchy (h1 -> h2) #176 - #177
Merged
Conversation
…s h2 (#176) PageShell renders the page title as h1, so section headings inside the dashboard should be h2 to avoid skipping a level. Pass `as="h2"` to SectionTitle in the Home page.
Deploying simple-module-python with
|
| Latest commit: |
f2438ec
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://de2710c6.simple-module-python.pages.dev |
| Branch Preview URL: | https://fix-176-dashboard-heading-hi.simple-module-python.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PageShellrenders the page title ash1, butSectionTitledefaulted toh3, skippingh2entirely.as="h2"to theSectionTitlecomponent inHome.tsxso the "System" section heading renders ash2.Closes #176
Test plan
<h2>element (inspect in browser DevTools)SectionTitlewithas="h2"usestext-lginstead oftext-base, which is the intended size for a top-level section