Skip to content

fix(cli): strip .github/workflows/ from workspace-bundled sample module #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antosubash merged 3 commits into from
May 13, 2026
Merged

fix(cli): strip .github/workflows/ from workspace-bundled sample module #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44e69fc
fix(cli): strip .github/workflows/ from workspace-bundled sample module
claude May 13, 2026
f6277ed
test(cli): fold .github strip assertion into existing workspace-layou…
claude May 13, 2026
bc8e71f
refactor(cli): tighten the workspace-mode .github strip
claude May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions framework/cli/simple_module_cli/app_project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

import json as _json
import secrets as _secrets
import shutil as _shutil
from collections.abc import Sequence
from importlib.metadata import PackageNotFoundError
from importlib.metadata import version as _pkg_version
Expand Down Expand Up @@ -181,6 +182,9 @@ def _scaffold_sample_module(target: Path) -> None:
if sample_dest.exists():
return
create_module(sample_dest, name=_SAMPLE_MODULE_NAME)
# GitHub only reads workflows from the repo root, so the template's
# .github/ is dead inside a workspace.
_shutil.rmtree(sample_dest / ".github")
_pin_sample_module_deps(sample_dest)
_seed_static_dist_placeholder(sample_dest / _SAMPLE_MODULE_NAME / "static" / "dist")

Expand Down
1 change: 1 addition & 0 deletions framework/cli/tests/test_cli_new.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,7 @@ def test_sm_new_default_lays_down_workspace_layout(tmp_path: Path) -> None:
assert (target / "host" / relpath).is_file(), f"missing host file: {relpath}"
for relpath in (".env.example", "README.md", ".gitignore", "Makefile"):
assert not (target / "host" / relpath).exists()
assert not (target / "modules" / "hello" / ".github").exists()


def test_sm_new_default_wires_workspace_in_pyproject(tmp_path: Path) -> None:
Expand Down
Loading