fix(cli): drop view_prefix from sample module template - #142
Merged
antosubash merged 2 commits intoMay 13, 2026
Conversation
The scaffolded `hello` module declared `view_prefix="/hello"` and overrode `register_routes` but shipped no views, menu items, or permissions, tripping the SM019 boot warning on every fresh `smpy new`. Drop `view_prefix` so the sample is API-only; authors who want a sidebar entry add `view_prefix` + `register_menu_items` together.
Deploying simple-module-python with
|
| Latest commit: |
0b2cfb7
|
| Status: | ⚡️ Build in progress... |
…module-emits-sm019-boot-6pm8v # Conflicts: # framework/cli/tests/test_cli_new_regressions.py
This was referenced May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hellomodule emits SM019 warning on every boot #138 — freshsmpy new myapp --yeswas emitting anSM019warning on every boot because the scaffoldedhellomodule declaredview_prefix="/hello"and overroderegister_routesbut shipped no views, menu items, or permissions.view_prefixfrom the module template so the sample is API-only by default; authors who want a sidebar entry addview_prefix+register_menu_itemstogether (the combination SM019 is designed to enforce).test_sm_new_sample_module_does_not_declare_view_prefixtotest_cli_new_regressions.pypinning the fix.Test plan
uv run pytest framework/cli/tests/test_cli_new_regressions.py— 4 passeduv run pytest framework/cli/tests/test_cli_new.py framework/core/tests/test_module_diagnostics.py— 35 passedsmpy new demo --yesboots withoutSM019in the doctor output