fix(cli): scaffold a Landing page at / so fresh apps don't 404 - #141
Merged
antosubash merged 1 commit intoMay 12, 2026
Merged
Conversation
The Quickstart promises `http://localhost:8000` is a landing page, but the CLI host template registered no `/` route — every fresh `smpy new` app 404'd on first visit. Add a host-owned `/` route (decoupled from the `dashboard` module) plus a minimal Tailwind Landing page to the template, and pin the behaviour with a regression test. Closes #137
Deploying simple-module-python with
|
| Latest commit: |
6a63493
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3b73cfba.simple-module-python.pages.dev |
| Branch Preview URL: | https://feature-feat-fresh-scaffold.simple-module-python.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
smpy newapp 404'd at/because the host template registered no root route, despite the Quickstart explicitly directing users there./route (in templateroutes.py, decoupled from thedashboardmodule) plus a minimal TailwindLanding.tsxthat flips its primary CTA between/dashboardand/users/loginbased on auth state.test_sm_new_registers_landing_route_at_rootso the 404 can't sneak back in.Closes #137
Test plan
uv run pytest framework/cli/tests/ -q— 106 passed including the new regression testsmpy new demo --yesagainst the built wheel, thenmake devandcurl -i http://localhost:8000/→ expect 200