chore(release): drop simple_module_datasets references - #103
Merged
Conversation
The datasets module was removed in #96 but its name was still listed in the release pipeline's publish-pypi matrix and in the 0.0.1 changelog entry. Remove the matrix row (which would otherwise fail the publish job with no matching artifacts) and update the historical package list + count to match what actually ships.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
simple_module_datasetsfrom the publish-pypi matrix in.github/workflows/release.yml. The module package was deleted in remove datasets and products modules, reset migrations #96, so the next release would have failed the matrix job with "no artifacts matched dist-py/simple_module_datasets-*".CHANGELOG.mdto drop the datasets package and correct the count from 14 → 13 to match what actually ships.No code changes — these are stale references left over from #96.
Test plan