Skip to content

Support multidimensional ports - #18

Open
mohamed wants to merge 1 commit into
antmicro:mainfrom
mohamed:feat/toplevel-multidim-ports
Open

Support multidimensional ports#18
mohamed wants to merge 1 commit into
antmicro:mainfrom
mohamed:feat/toplevel-multidim-ports

Conversation

@mohamed

@mohamed mohamed commented Aug 6, 2026

Copy link
Copy Markdown

Add support for multidimensional design and IP ports.
This is achieved by using the bound property to specify the port dimensions.

Comment thread tests/tests_ir/backend/test_yaml.py Outdated
Comment thread tests/tests_ir/frontend/test_yaml.py Outdated
@tmichalak

Copy link
Copy Markdown
Member

@mohamed Please fix the issues pointed out by the linter

Comment thread topwrap/backend/yaml/common/ip_core_schema.py Outdated
@kslominski-ant

Copy link
Copy Markdown
Contributor

I think it would be a good idea to add tests for arrays with more than two dimensions. I also think a test going from a design YAML with a multidimensional port to a SystemVerilog module would be good to have, to make sure we generate the correct syntax etc.

@mohamed

mohamed commented Aug 13, 2026

Copy link
Copy Markdown
Author

@tmichalak @kslominski-ant The branch has been updated. Please have a look and let me know if you have further comments

@tmichalak

Copy link
Copy Markdown
Member

Please update the documentation. Apart from this squash the commits and rebase your branch.

@mohamed
mohamed force-pushed the feat/toplevel-multidim-ports branch from 85d9af8 to fec1bb1 Compare August 14, 2026 11:48
@mohamed

mohamed commented Aug 14, 2026

Copy link
Copy Markdown
Author

@tmichalak Documentation has been updated. Please have a look and let me know if there are further changes needed.

@mohamed
mohamed force-pushed the feat/toplevel-multidim-ports branch 3 times, most recently from 3dfd0c2 to 8ac7064 Compare August 19, 2026 13:28
@mohamed

mohamed commented Aug 20, 2026

Copy link
Copy Markdown
Author

@tmichalak @kslominski-ant I have squashed the commits and rebased the branch.

@mohamed
mohamed force-pushed the feat/toplevel-multidim-ports branch 2 times, most recently from 3c8fb4a to dc044cf Compare August 20, 2026 12:19
Add support for multidimensional design and IP ports.
This is achieved by using the `bound` property to specify the port dimensions.

Signed-off-by: Mohamed A. Bamakhrama <mohamed.bamakhrama@imec-int.com>
@mohamed
mohamed force-pushed the feat/toplevel-multidim-ports branch from dc044cf to c3d4f22 Compare August 25, 2026 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants