Support multidimensional ports - #18
Open
mohamed wants to merge 1 commit into
Open
Conversation
tmichalak
reviewed
Aug 13, 2026
tmichalak
reviewed
Aug 13, 2026
Member
|
@mohamed Please fix the issues pointed out by the linter |
Contributor
|
I think it would be a good idea to add tests for arrays with more than two dimensions. I also think a test going from a design YAML with a multidimensional port to a SystemVerilog module would be good to have, to make sure we generate the correct syntax etc. |
Author
|
@tmichalak @kslominski-ant The branch has been updated. Please have a look and let me know if you have further comments |
Member
|
Please update the documentation. Apart from this squash the commits and rebase your branch. |
mohamed
force-pushed
the
feat/toplevel-multidim-ports
branch
from
August 14, 2026 11:48
85d9af8 to
fec1bb1
Compare
Author
|
@tmichalak Documentation has been updated. Please have a look and let me know if there are further changes needed. |
mohamed
force-pushed
the
feat/toplevel-multidim-ports
branch
3 times, most recently
from
August 19, 2026 13:28
3dfd0c2 to
8ac7064
Compare
Author
|
@tmichalak @kslominski-ant I have squashed the commits and rebased the branch. |
mohamed
force-pushed
the
feat/toplevel-multidim-ports
branch
2 times, most recently
from
August 20, 2026 12:19
3c8fb4a to
dc044cf
Compare
Add support for multidimensional design and IP ports. This is achieved by using the `bound` property to specify the port dimensions. Signed-off-by: Mohamed A. Bamakhrama <mohamed.bamakhrama@imec-int.com>
mohamed
force-pushed
the
feat/toplevel-multidim-ports
branch
from
August 25, 2026 11:13
dc044cf to
c3d4f22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for multidimensional design and IP ports.
This is achieved by using the
boundproperty to specify the port dimensions.