Ignore up arrow key #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! I am frontend developer I want to work with you.
…________________________________
From: HowardChan ***@***.***>
Sent: 16 November 2023 12:38
To: antirez/smallchat ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [antirez/smallchat] Ignore up arrow key (PR #47)
Hi there! I created this pull request because I discovered that it's possible to easily alter the logs of smallchat-server or the chat history of smallchat-client using the up arrow key.
In other words, you can easily hack the smallchat-client simply using up arrow key, before doing this if you change you nick by "/nick you", things will be more interesting! :) Lol, just for kidding.
We can simply solve this problem by ignoring the up arrow key, while we reading from stdin.
[image]<https://user-images.githubusercontent.com/28386363/283355794-5fa2062d-40f6-4d00-a40a-e558b36a2c57.png>
[image]<https://user-images.githubusercontent.com/28386363/283355863-9a238758-9ff6-4a9e-a49e-7b16a78049ae.png>
________________________________
You can view, comment on, or merge this pull request online at:
#47
Commit Summary
* b10dcfd<b10dcfd> Ignore up arrow key
File Changes
(1 file<https://github.com/antirez/smallchat/pull/47/files>)
* M smallchat-client.c<https://github.com/antirez/smallchat/pull/47/files#diff-8acb56e59641c5ea37ee9051cc9be2ced4db236a42db6acfd1d2e5791d71c66a> (5)
Patch Links:
* https://github.com/antirez/smallchat/pull/47.patch
* https://github.com/antirez/smallchat/pull/47.diff
—
Reply to this email directly, view it on GitHub<#47>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BABL5DV5WLPW4VOKTMJ5423YEW7GVAVCNFSM6AAAAAA7NWCU6WVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE4TMMRUHE2DKNA>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
|
what? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! I created this pull request because I discovered that it's possible to easily alter the logs of smallchat-server or the chat history of smallchat-client using the up arrow key.
In other words, you can easily hack the smallchat-client simply using up arrow key, before doing this if you change you nick by "/nick you", things will be more interesting! :) Lol, just for kidding.
We can simply solve this problem by ignoring the up arrow key, while we reading from stdin.