Skip to content

FEAT: Add lock option removal for save_as method #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 22, 2025
Merged

Conversation

dipinknair
Copy link
Collaborator

@dipinknair dipinknair commented Jul 11, 2025

This pull request introduces enhancements to the save_as method in the app.py file, including the addition of a remove_lock option, and replaces warnings with logging for better error handling. Additionally, it updates the changelog to document these changes.

Enhancements to save_as method:

  • Added a new remove_lock parameter to the save_as method, allowing users to remove lock files before saving the project. This provides more flexibility when dealing with locked project files.
  • Enhanced error handling in save_as by logging detailed error messages, including a hint for resolving lock-related issues, and raising exceptions when saving fails.

Logging improvements:

  • Replaced warnings.warn with self.log_warning in the open method to standardize logging and improve message clarity.

@dipinknair dipinknair requested review from koubaa and klmcadams July 11, 2025 15:39
@dipinknair dipinknair marked this pull request as ready for review July 11, 2025 15:39
@dipinknair dipinknair requested a review from a team as a code owner July 11, 2025 15:39
@github-actions github-actions bot added the enhancement New features or code improvements label Jul 11, 2025
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 11, 2025
Copy link

codacy-production bot commented Jul 14, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 59230251 29.41%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5923025) Report Missing Report Missing Report Missing
Head commit (b139ed8) 2557 2196 85.88%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1233) 17 5 29.41%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link

codecov bot commented Jul 14, 2025

Codecov Report

Attention: Patch coverage is 29.41176% with 12 lines in your changes missing coverage. Please review.

Project coverage is 85.88%. Comparing base (9865594) to head (b139ed8).
Report is 2 commits behind head on main.

❌ Your patch status has failed because the patch coverage (29.41%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1233      +/-   ##
==========================================
- Coverage   86.20%   85.88%   -0.33%     
==========================================
  Files          39       39              
  Lines        2544     2557      +13     
==========================================
+ Hits         2193     2196       +3     
- Misses        351      361      +10     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dipinknair dipinknair requested a review from klmcadams July 14, 2025 17:49
@dipinknair dipinknair enabled auto-merge (squash) July 22, 2025 19:57
@dipinknair dipinknair merged commit 7bf03f6 into main Jul 22, 2025
54 of 55 checks passed
@dipinknair dipinknair deleted the feat/save-as branch July 22, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants