Skip to content

fix: adding console testing #3791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Apr 15, 2025
Merged

fix: adding console testing #3791

merged 17 commits into from
Apr 15, 2025

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Mar 10, 2025

Description

Fixing console testing by adding --console flag.

I had to not finish this PR. MAPDL keeps crashing showing Ansys Traceback but I do not have much time to debug this.
So I am merging without that flag, with the partial changes since I think they are useful.

It only fails on the latest v25.2 so it might be due to parsing issues (extra printout due to beta versions)

Issue linked

Related #3790

Checklist

@germa89 germa89 requested a review from a team as a code owner March 10, 2025 18:43
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Mar 10, 2025
@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc) bug Issue, problem or error in PyMAPDL labels Mar 10, 2025
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.36%. Comparing base (e0dd5d6) to head (90fbc1e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3791   +/-   ##
=======================================
  Coverage   88.36%   88.36%           
=======================================
  Files         187      187           
  Lines       14761    14761           
=======================================
  Hits        13044    13044           
  Misses       1717     1717           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89 germa89 enabled auto-merge (squash) April 2, 2025 10:28
@germa89
Copy link
Collaborator Author

germa89 commented Apr 14, 2025

@pyansys-ci-bot LGTM.

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit bcb7f35 into main Apr 15, 2025
48 checks passed
@germa89 germa89 deleted the ci/fix-console-testing branch April 15, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue, problem or error in PyMAPDL CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants