Skip to content

feat: database submodule #3748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Apr 23, 2025
Merged

feat: database submodule #3748

merged 26 commits into from
Apr 23, 2025

Conversation

clatapie
Copy link
Contributor

Description

This PR follows the PyConverter-XML2Py integration plan to automate the PyMAPDL_commands documentation.
The changes have been generated using pyconverter-xml2py and more specifically mapdl-cmd-conv.

This PR focus on the database submodule.

Pinging @ansys/pymapdl-developers for visibility. Feel free to provide any feedback on the way the docstrings and the source code generation are handled.

Issue linked

This PR is meant to be merged within the feat/main_commands branch. The latter will gather all the submodule changes, one by one, prior to be merged to the main branch.

Checklist

@clatapie clatapie self-assigned this Feb 17, 2025
@clatapie clatapie requested a review from a team as a code owner February 17, 2025 17:28
@clatapie clatapie requested review from germa89 and pyansys-ci-bot and removed request for a team February 17, 2025 17:28
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added documentation Documentation related (improving, adding, etc) new feature Request or proposal for a new feature labels Feb 17, 2025
@clatapie clatapie changed the title feat: adding database submodule feat: database submodule Feb 17, 2025
germa89
germa89 reviewed Feb 18, 2025
View reviewed changes
germa89
germa89 approved these changes Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work over all. Some minor comments/fix are needed.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025 •
edited by unfurl-links bot
Loading

The towncrier template has been successfully rewritten with the default template.
Please ensure that sphinx-design is included as a dependency in your project's documentation requirements.
Additionally, add sphinx-design to the extensions list in your conf.py file.
For more information, please refer to the migration guide at:
https://actions.docs.ansys.com/version/stable/migrations/index.html#migration-guide

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc dependencies maintenance General maintenance of the repo (libraries, cicd, etc) labels Mar 7, 2025
@github-actions github-actions bot removed CI/CD Related with CICD, Github Actions, etc dependencies maintenance General maintenance of the repo (libraries, cicd, etc) labels Mar 7, 2025
@RobPasMue
Copy link
Member

@clatapie - what's missing here? Can we have it merged?

@github-actions github-actions bot removed the documentation Documentation related (improving, adding, etc) label Apr 15, 2025
@github-actions github-actions bot added the documentation Documentation related (improving, adding, etc) label Apr 15, 2025
@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc) labels Apr 16, 2025
@clatapie clatapie mentioned this pull request Apr 18, 2025
Open
@clatapie
Copy link
Contributor Author

The submodule is ready for another review if needed. Otherwise, it can be merged to feat/main_commands.
Pinging @germa89 and @RobPasMue for visibility.

RobPasMue
RobPasMue approved these changes Apr 21, 2025
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me again -- up to @germa89 to merge

germa89
germa89 approved these changes Apr 21, 2025
View reviewed changes
Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering about table rendering. Please do double check those. Other than that, this is looking good to me for merging.

@clatapie clatapie merged commit 1c9ac58 into feat/main_commands Apr 23, 2025
43 checks passed
@clatapie clatapie deleted the feat/database_submodule branch April 23, 2025 08:36
@clatapie clatapie mentioned this pull request Jun 30, 2025
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@germa89 germa89 germa89 approved these changes

@RobPasMue RobPasMue RobPasMue approved these changes

@MaxJPRey MaxJPRey MaxJPRey approved these changes

@pyansys-ci-bot pyansys-ci-bot Awaiting requested review from pyansys-ci-bot pyansys-ci-bot was automatically assigned from ansys/pymapdl-maintainers

Assignees

@clatapie clatapie

Labels
CI/CD Related with CICD, Github Actions, etc documentation Documentation related (improving, adding, etc) maintenance General maintenance of the repo (libraries, cicd, etc) new feature Request or proposal for a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@clatapie @RobPasMue @germa89 @MaxJPRey @pyansys-ci-bot