Skip to content

remove explicit calls to PyQt5 #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025
Merged

remove explicit calls to PyQt5 #356

merged 1 commit into from
Jul 17, 2025

Conversation

mariostieriansys
Copy link
Collaborator

We are on the verge of moving from Qt5 to Qt6

As part of this effort, we need to remove all the explicit calls to PyQt5 and use the qtpy wrapper, which adapts to the underlying Qt environment

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.53%. Comparing base (f71c77e) to head (e254138).

Files with missing lines Patch % Lines
...dynamicreporting/core/utils/report_download_pdf.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #356   +/-   ##
=======================================
  Coverage   80.53%   80.53%           
=======================================
  Files          25       25           
  Lines        7163     7163           
  Branches     1347     1347           
=======================================
  Hits         5769     5769           
  Misses        976      976           
  Partials      418      418           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mariostieriansys mariostieriansys enabled auto-merge (squash) July 17, 2025 11:53
@mariostieriansys mariostieriansys merged commit af37e8b into main Jul 17, 2025
19 checks passed
@mariostieriansys mariostieriansys deleted the mostieri/qtpy branch July 17, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants