Skip to content

feat(plotter): enable plots of mesh scopings #2377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jun 19, 2025
Merged

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Jun 17, 2025

Solves #1245

TODO:

  • Add DpfPlotter.add_scoping
  • Add Scoping.plot
  • Add ScopingsContainer.plot
  • Add testing
  • Investigate possibility of faces scoping

@PProfizi PProfizi self-assigned this Jun 17, 2025
@PProfizi PProfizi added the enhancement New feature or request label Jun 17, 2025
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

Attention: Patch coverage is 97.91667% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.17%. Comparing base (fb1fd63) to head (6d660e8).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2377      +/-   ##
==========================================
+ Coverage   84.07%   84.17%   +0.10%     
==========================================
  Files          91       91              
  Lines       10540    10584      +44     
==========================================
+ Hits         8861     8909      +48     
+ Misses       1679     1675       -4     

@PProfizi PProfizi requested a review from rafacanton June 17, 2025 17:48
Copy link
Contributor

The documentation for this pull request will be available at https://dpf.docs.pyansys.com/pull/2377. Please allow some time for the documentation to be deployed.

@PProfizi
Copy link
Contributor Author

PS: codecoverage reporting is broken. Here coverage on new lines is 100%.

@PProfizi PProfizi merged commit a5dbf84 into master Jun 19, 2025
82 of 83 checks passed
@PProfizi PProfizi deleted the feat/scoping_plot branch June 19, 2025 14:35
Copy link
Contributor

This PR has been closed. Documentation for this pull request will shortly be removed from its former deployment address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants