Convert DAT file to CDB for import into Mechanical #896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: In the 'CDB to Mechanical' workflow, using a DAT file (as exported from Mechanical) can fail when e.g. the layup only covers part of the mesh (see #826). This can be fixed by converting the DAT file to a CDB file using MAPDL. This improves the reliability of loading the model into Mechanical, and allows re-enabling the 'valid blocked CDB' check in the import. Changes: - Enable the 'valid blocked CDB' check in the `import_acp_mesh_from_cdb` helper function. - Update the 'Create input file' documentation to include the conversion from DAT to CDB using (Py)MAPDL. - Add a conversion from DAT to CDB to the 'CDB to Mechanical' workflow example. Closes #826.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #896 +/- ##
=======================================
Coverage 94.97% 94.97%
=======================================
Files 110 110
Lines 5773 5773
Branches 296 296
=======================================
Hits 5483 5483
Misses 289 289
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR improves the reliability of the 'CDB to Mechanical' workflow by converting DAT files to CDB format using MAPDL before importing into Mechanical. This addresses issues where DAT files fail to import when layups only partially cover the mesh.
- Enables the 'valid blocked CDB' check by default in the import helper function
- Adds DAT to CDB conversion using PyMAPDL in workflow examples
- Updates documentation to include the conversion process and its benefits
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ansys/acp/core/mechanical_integration_helpers.py | Adds configurable parameter to enable valid blocked CDB file checking by default |
| examples/workflows/06-cdb-to-pymechanical-workflow.py | Converts DAT input to CDB format using PyMAPDL before processing |
| examples/workflows/05-pymechanical-to-cdb-workflow.py | Updates workflow to export DAT then convert to CDB format |
| examples/workflows/04-pymechanical-solid-workflow.py | Explicitly disables CDB validation for solid model workflow |
| doc/source/user_guide/howto/create_input_file.rst | Documents the DAT to CDB conversion process and its benefits |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
In the 'CDB to Mechanical' workflow, using a DAT file (as exported
from Mechanical) can fail when e.g. the layup only covers part of
the mesh (see #826).
This can be fixed by converting the DAT file to a CDB file
using MAPDL. This improves the reliability of loading the model
into Mechanical, and allows re-enabling the 'valid blocked CDB'
check in the import.
Changes:
import_acp_mesh_from_cdbhelper function by default (configurable).
from DAT to CDB using (Py)MAPDL.
and 'Mechanical to CDB' examples.
Closes #826.