Generalize edge property type implementation #607
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow marking gRPC properties as supported since a specific server version. The `grpc_data_property_read_only` is given a `supported_since` keyword, and `grpc_data_property` is given two separate keywords `readable_since` and `writable_since`. Other changes: - Change the `xfail_before` test fixture to `raises_before_version`, which explicitly checks that a `RuntimeError` is raised when run on an older server version. - Move the `supported_since` implementation to a separate file. - In the CI definition, reuse the `DOCKER_IMAGE_NAME` variable in more places.
Add a '_SUPPORTED_SINCE' class attribute to the 'GrpcObjectBase' class, which has two effects: - upon storing an object, check the server version and raise an appropriate exception if the server version is too low - in the 'mark_grpc_properties' class decorator, add a line at the end of the class docstring indicating the server version at which the class was introduced
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/582-add-buttjointsequence #607 +/- ##
==================================================================
- Coverage 93.19% 93.11% -0.08%
==================================================================
Files 86 86
Lines 4583 4619 +36
==================================================================
+ Hits 4271 4301 +30
- Misses 312 318 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
greschd
force-pushed
the
feat/582-add-buttjointsequence
branch
from
9853384 to
84cd4de
Compare
greschd
force-pushed
the
feat/582-add-buttjointsequence
branch
3 times, most recently
from
ee05fe5 to
774123c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stores the linked object within the protobuf message (w/ resource path) + keeps its server wrapper for instantiating. The previous implementation directly stored the linked object, but that's more difficult to generalize w.r.t.
_to_pb_object/_from_pb_object.TODO:
allowed_typesto be dependent on the parent type (needed forLinkedSelectionRule)_to_pb_object, or is it ok to return the internal object directly?