Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded ansible-lint upper bound to 25.1.2 #327

Merged
merged 2 commits into from
Feb 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES/38371.feature
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Upgraded the ansible-lint dependency upper bound from 24.9.0 to 25.1.2.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

``galaxy-importer`` requires the following other Ansible projects:

* ``ansible-lint`` up to [24.9.0](https://github.com/ansible/ansible-lint/tree/v24.9.0/docs)
* ``ansible-lint`` up to [25.1.2](https://github.com/ansible/ansible-lint/tree/v25.1.2/docs)
* ``ansible-core`` up to [2.16](https://docs.ansible.com/ansible-core/2.16/index.html)

If you are installing from source, see ``setup.cfg`` in the repository for the matching requirements.
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ packages = find:
install_requires =
ansible-core
ansible-builder>=1.2.0,<4.0
ansible-lint>=6.2.2,<=24.9.0
ansible-lint>=6.2.2,<=25.1.2
attrs>=21.4.0,<23
nh3>=0.2.18,<3 # replaces bleach
flake8>=5.0.0,<7
Expand Down
6 changes: 2 additions & 4 deletions tests/unit/test_loader_collection.py
Original file line number Diff line number Diff line change
Expand Up @@ -631,10 +631,8 @@ def test_ansiblelint_collection_role_errors(populated_collection_root, tmp_colle
collection_loader._lint_collection()
shutil.rmtree(task_dir)

assert "name[casing]: All names should start with an uppercase letter." in str(
caplog.records[0]
)
assert "jinja[spacing]: Jinja2 spacing could be improved:" in str(caplog.records[1])
assert "All names should start with an uppercase letter." in str(caplog.records[0])
assert "Jinja2 spacing could be improved:" in str(caplog.records[1])


def test_ansiblelint_collection_meta_runtime_errors(
Expand Down
Loading