Show more info when Legacy role galaxy info has unknown field #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@markgoddard sorry i've been neglecting this queue. Can you sign your commit so I can get it merged? https://ansible.readthedocs.io/projects/galaxy-ng/en/latest/community/devstack/#commits |
markgoddard
force-pushed
the
fix-role-galaxy-info-error
branch
from
e87096b to
3e0173f
Compare
Currently during legacy role import, if galaxy_info has an unknown field, we see the following message: unknown field in galaxy_info This is not very helpful, and does not tell us how to fix the issue. This change adds the cause of the issue to the exception message, so we know which field to fix. No-Issue Signed-off-by: Mark Goddard <[email protected]>
markgoddard
force-pushed
the
fix-role-galaxy-info-error
branch
from
3e0173f to
196d1b7
Compare
No problem, sorry for ignoring the CI result :) Now passes the commit check |
jctanner
approved these changes
Jan 3, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently during legacy role import, if galaxy_info has an unknown
field, we see the following message:
unknown field in galaxy_info
This is not very helpful, and does not tell us how to fix the issue.
This change adds the cause of the issue to the exception message, so we
know which field to fix.