Skip to content

feat: Change default isolation mode from 'restrictive' to 'cfg' #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 28, 2025

Conversation

cidrblock
Copy link
Collaborator

@cidrblock cidrblock commented Jul 15, 2025

Closes: #338

Summary

This PR changes the default isolation mode from 'restrictive' to 'cfg' to provide better workspace isolation by default.

Changes Made

  • Updated default isolation mode: Changed from 'restrictive' to 'cfg' in arg_parser.py
  • Updated test cases: Modified tests to explicitly specify --im restrictive where the restrictive mode behavior is specifically being tested
  • Maintained backward compatibility: All existing functionality remains available through explicit flags

Why This Change?

The 'cfg' isolation mode provides better workspace isolation by creating/updating an ansible.cfg file in the current working directory. This approach is more user-friendly and provides clearer workspace boundaries compared to the 'restrictive' mode.

Testing

  • All existing tests have been updated to maintain their intended behavior
  • Tests that specifically need restrictive mode now explicitly specify it
  • No breaking changes to the API - users can still use any isolation mode via the --im flag

Impact

  • Users upgrading: Will get 'cfg' isolation mode by default instead of 'restrictive'
  • Existing scripts: Can continue to work by explicitly specifying --im restrictive if needed
  • New users: Will get a better default experience with clearer workspace isolation

- Update default isolation mode to 'cfg' in arg_parser.py
- Update test cases to explicitly use 'restrictive' mode where needed
- This makes the cfg isolation mode the default behavior for better workspace isolation
@cidrblock cidrblock requested a review from a team as a code owner July 15, 2025 20:03
@cidrblock cidrblock added the enhancement New feature or request label Jul 15, 2025
@cidrblock cidrblock enabled auto-merge (squash) July 23, 2025 13:29
@cidrblock cidrblock merged commit e578ab2 into ansible:main Jul 28, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

RFE: Change default isolation mode to cfg
2 participants