Make the searchbox configurable #121
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
requested changes
Nov 19, 2025
Collaborator
felixfontein
left a comment
felixfontein
left a comment
There was a problem hiding this comment.
This is a breaking change. The theme is not only used by the docsite, but also by other projects. This must be made configurable, with default being the current behavior (searchbox visible).
Add a "display_searchbox" option that is set to True by default so that projects can choose to show the search box in the theme or not.
felixfontein
approved these changes
Nov 23, 2025
Collaborator
Author
|
Thanks for the review @felixfontein |
Collaborator
|
I think this one isn't a bugfix, but a new feature. But since we're in the 0.x.y version range semver doesn't really count anyway... :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a "display_searchbox" option that is set to True by default so that projects can choose to show the search box in the theme or not.