DHCPv6 client: add missing 'use-interface-duid' option #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #341 +/- ##
=======================================
Coverage 84.63% 84.63%
=======================================
Files 33 33
Lines 4112 4112
Branches 879 879
=======================================
Hits 3480 3480
Misses 452 452
Partials 180 180
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
changelogs/fragments/341-add-dhcpv6-client-use-interface-duid.yml
Outdated
Show resolved
Hide resolved
petrows
force-pushed
the
Add-dhcpv6-use-interface-duid
branch
from
1c0afc2 to
d136f8b
Compare
* script * custom-duid * use-interface-duid * validate-server-duid
petrows
force-pushed
the
Add-dhcpv6-use-interface-duid
branch
from
d136f8b to
3ee2a7a
Compare
felixfontein
approved these changes
Jan 26, 2025
|
@petrows thanks again for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
api_info, api_modify: add the
use-interface-duidoption for DHCPv6 client.ISSUE TYPE
COMPONENT NAME
api_info, api_modify
ADDITIONAL INFORMATION
This option prevents issues with Fritzbox modems and routers, when using virtual interfaces (like VLANs) may create duplicated records in hosts config, this breaks original "expose-host" function.
The
use-interface-duidcorrects this behavior: the DUID for link-local address and DHCPv6 request are the same, and user can configure per-host option in Fritzbox OS as expected.Tested on current
7.17and7.16.2versions: