Fix #216 VXLAN zone configuration to support both fabric or peers #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelwdombek
force-pushed
the
I216_vxlan_unsuported_peers
branch
from
0654237 to
d2030f1
Compare
michaelwdombek
changed the title
This commit allows to use 1. A fabric (automated routing between nodes) 2. A peers list (manual comma-separated IP addresses) for VXLAN Zones - as per documentation adds some basic tests Signed-off-by: Michael Dombek <[email protected]>
Signed-off-by: Michael Dombek <[email protected]>
michaelwdombek
force-pushed
the
I216_vxlan_unsuported_peers
branch
from
403e28d to
baf18ce
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #217 +/- ##
==========================================
+ Coverage 66.43% 66.80% +0.37%
==========================================
Files 73 73
Lines 7437 7505 +68
Branches 1404 1420 +16
==========================================
+ Hits 4941 5014 +73
+ Misses 2264 2262 -2
+ Partials 232 229 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Thanks for this! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #216
This PR allows to use
1. A fabric (automated routing between nodes)
2. A peers list (manual comma-separated IP addresses) for VXLAN Zones - as per proxmox documentation VXLAN Zone docu
ISSUE TYPE
COMPONENT NAME
community.proxmox.proxmox_zone.py
ADDITIONAL INFORMATION
Bug occurs when trying to create a VXLAN Zone it requires to have a fabric set up to use