Release 3.2.0 #1038
Closed
Release 3.2.0 #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[PR #882/5e5f7547 backport][stable-3] migrate from ansible.netcommon to ansible.utils This is a backport of PR #882 as merged into main (5e5f754). SUMMARY This is a maintenance task to migrate from ansible.netcommon to ansible.utils. I was trying to fix an issue in that module, but I was told the functions have moved to ansible.utils. See ansible-collections/ansible.netcommon#362 (comment) ISSUE TYPE Bugfix Pull Request COMPONENT NAME Existing integration tests that use the ansible.netcommon module. No module uses netcommon, only integration tests. ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None>
Lambda - Wait before updating SUMMARY Updated lambda module to wait for State = Active & LastUpdateStatus = Successful based on https://aws.amazon.com/blogs/compute/coming-soon-expansion-of-aws-lambda-states-to-all-functions/ Fixes #830 ISSUE TYPE Bugfix Pull Request COMPONENT NAME module: lambda ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> (cherry picked from commit ab4bda2) Co-authored-by: Andreas Jonsson <[email protected]>
Improve doc of ec2_launch_template module SUMMARY Add information about how the ec2_launch_template handles initial creation of the launch template, or creation of a new version of the launch template. ISSUE TYPE Docs Pull Request COMPONENT NAME ec2_launch_template ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Mark Chappell <None> (cherry picked from commit 37d758e) Co-authored-by: Sebastien Rosset <[email protected]>
aws_acm: fix yamllint errors in docs section SUMMARY Closes: #902 ISSUE TYPE Docs Pull Request COMPONENT NAME aws_acm ADDITIONAL INFORMATION 1:1 warning missing document start "---" (document-start) 2:81 error line too long (88 > 80 characters) (line-length) 5:81 error line too long (89 > 80 characters) (line-length) 9:81 error line too long (86 > 80 characters) (line-length) 11:81 error line too long (100 > 80 characters) (line-length) 32:81 error line too long (87 > 80 characters) (line-length) 36:81 error line too long (98 > 80 characters) (line-length) 41:81 error line too long (98 > 80 characters) (line-length) 43:81 error line too long (105 > 80 characters) (line-length) 49:81 error line too long (84 > 80 characters) (line-length) 56:81 error line too long (102 > 80 characters) (line-length) 61:81 error line too long (87 > 80 characters) (line-length) 69:81 error line too long (91 > 80 characters) (line-length) 79:81 error line too long (92 > 80 characters) (line-length) 88:81 error line too long (85 > 80 characters) (line-length) 105:81 error line too long (83 > 80 characters) (line-length) 123:1 error wrong indentation: expected 2 but found 0 (indentation) 124:17 error no new line character at the end of file (new-line-at-end-of-file) Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Mark Chappell <None> (cherry picked from commit d52052a) Co-authored-by: Markus Bergholz <[email protected]>
Cleanup unused imports (#852 / #892) Let's try once more... SUMMARY My local tests are flagging that we've picked up some unused imports again. ISSUE TYPE Feature Pull Request COMPONENT NAME aws_glue_job cloudfront_info rds_option_group_info ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> (cherry picked from commit 017081c) Co-authored-by: Mark Chappell <[email protected]>
…) (#911) [PR #881/cecc9e80 backport][stable-3] Fix cloudfront_distribution s3_origin_access_identity_enabled bug This is a backport of PR #881 as merged into main (cecc9e8). SUMMARY If s3_origin_access_identity_enabled is set to True but no s3_origin_config then a default origin config is applied however it also picks up s3_origin_access_identity_enabled as S3OriginAccessIdentityEnabled and passes it to the API request which is not a valid option to be passed and then fails validation. Fixes: #749 ISSUE TYPE Bugfix Pull Request COMPONENT NAME cloudfront_distribution ADDITIONAL INFORMATION The option mention is not valid for the API request: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/cloudfront.html#CloudFront.Client.create_distribution
[PR #763/08f95cc6 backport][stable-3] aws_ssm connection: add SSE encryption parameters. This is a backport of PR #763 as merged into main (08f95cc). SUMMARY Add the following parameters to aws_ssm.py connection plugin: ansible_aws_ssm_bucket_sse_mode ansible_aws_ssm_bucket_sse_kms_key_id ISSUE TYPE Feature Pull Request COMPONENT NAME aws_ssm connection plugin ADDITIONAL INFORMATION This allows the connection plugin to work when encryption parameters are required for uploads on the file transfer bucket by policy / SCP (see here for an example).
[PR #917/d47e188d backport][stable-3] ec2_launch_template: implement missing metadata options This is a backport of PR #917 as merged into main (d47e188). SUMMARY Add missing metadata options instance_metadata_tags http_protocol_ipv6 ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_launch_template
[PR #918/0e08a409 backport][stable-3] Update the name attribute value in the examples This is a backport of PR #918 as merged into main (0e08a40). SUMMARY Problem- All the examples had same name key value irrespective of different purposes of the tasks Action taken - Made changes in the name of the tasks under examples Corrected it with relevant name key value to the comments of the task ISSUE TYPE Docs Pull Request COMPONENT NAME ADDITIONAL INFORMATION
…926) [PR #913/55962ff2 backport][stable-3] Add deregistration_connection_termination to elb_target_group This is a backport of PR #913 as merged into main (55962ff). SUMMARY Adding support for the deregistration_connection_termination param in the elb_target_group module. Along with this I've enabled and fixed up the integration tests. ISSUE TYPE Feature Pull Request COMPONENT NAME elb_target_group ADDITIONAL INFORMATION The API param is deregistration_delay.connection_termination.enabled https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/elbv2.html#ElasticLoadBalancingv2.Client.describe_target_group_attributes
) [PR #865/ca1d33ff backport][stable-3] Add AWSRetry backoff logic to route53_zone and route53_info This is a backport of PR #865 as merged into main (ca1d33f). SUMMARY Add AWSRetry backoff logic to route53_zone and route53_info. Currently from time to time I've been hitting AWS throttling errors leading to ansible failures: An exception occurred during task execution. To see the full traceback, use -vvv. The error was: botocore.exceptions.ClientError: An error occurred (Throttling) when calling the ListHostedZones operation (reached max retries: 4): Rate exceeded fatal: [localhost_staging -> 127.0.0.1]: FAILED! => changed=false boto3_version: 1.20.34 botocore_version: 1.23.34 error: code: Throttling message: Rate exceeded type: Sender msg: 'Could not list current hosted zones: An error occurred (Throttling) when calling the ListHostedZones operation (reached max retries: 4): Rate exceeded' response_metadata: http_headers: connection: close content-length: '255' content-type: text/xml date: Fri, 14 Jan 2022 12:09:35 GMT x-amzn-requestid: xxxxxxx http_status_code: 400 max_attempts_reached: true request_id: xxxxxxx retry_attempts: 4 ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53_zone route53_info ADDITIONAL INFORMATION I've added the standard backoff retry logic and split out the paginators.
) [PR #878/45e79ed2 backport][stable-3] Fix IOPs io1 DB instance updates and integration tests also This is a backport of PR #878 as merged into main (45e79ed). SUMMARY Primary this PR is to fix updates when updating iops or allocated_storage on io1 DB instances when only one param is changing. Secondarily this fixes up the tests again and is test against some improvements to the waiter configuration see linked PR. IOPs error on update attempts if only one param is being updated: error: code: InvalidParameterCombination message: You must specify both the storage size and iops when modifying the storage size or iops on a DB instance that has iops. type: Sender msg: 'Unable to modify DB instance: An error occurred (InvalidParameterCombination) when calling the ModifyDBInstance operation: You must specify both the storage size and iops when modifying the storage size or iops on a DB instance that has iops.' ISSUE TYPE Bugfix Pull Request COMPONENT NAME rds_instance ADDITIONAL INFORMATION These tests are very slow and still a little flakey but generally all pass as expected now locally.
#928) [PR #872/716ae77f backport][stable-3] ec2_placement_group: Add partition strategy and partition count This is a backport of PR #872 as merged into main (716ae77). SUMMARY Add partition as a strategy and an option, partition_count to choose the actual number of partitions for the community.aws.ec2_placement_group module. Fixes #808 ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_placement_group ADDITIONAL INFO Tested locally with - name: Create a partition placement group with partition count 4. ec2_placement_group: name: my-cluster state: present strategy: partition partition_count: 4
[PR #880/15d69c91 backport][stable-3] Add dynamodb table class support This is a backport of PR #880 as merged into main (15d69c9). SUMMARY Add support for defining a TableClass on DynamoDB tables. TableClass was introduced as part of botocore version 1.23.18 https://github.com/boto/botocore/blob/develop/CHANGELOG.rst#12318 Fixes: #829 ISSUE TYPE Feature Pull Request COMPONENT NAME dynamodb_table ADDITIONAL INFORMATION https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/dynamodb.html#DynamoDB.Client.create_table https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/dynamodb.html#DynamoDB.Client.update_table
#721) (#934) [PR #721/c91acf6a backport][stable-3] Extended the wafv2_web_acl module with custom_response_bodies argument This is a backport of PR #721 as merged into main (c91acf6). SUMMARY Extended the wafv2_web_acl module to also take the custom_response_bodies argument, improved docs and extended tests ISSUE TYPE Feature Pull Request COMPONENT NAME wafv2_web_acl ADDITIONAL INFORMATION Also touched docs of aws_waf_web_acl to make it easier to find the WAF v2 modules as I had trouble finding that at first.
…935) [PR #893/44daa2de backport][stable-3] Refactor iam_managed_policy module and add integration tests This is a backport of PR #893 as merged into main (44daa2d). SUMMARY Refactor iam_managed_policy module to: Improve AWS retry backoff logic Add check_mode support Fix module exit on updates to policies when no changes are present Other changes: Add disabled integration tests ISSUE TYPE Bugfix Pull Request COMPONENT NAME iam_managed_policy ADDITIONAL INFORMATION Backoff logic only partially covered the module, and it didn't support check_mode or have any integration tests. Due to the nature of the IAM based modules the tests are intentionally disabled but have been run locally: ansible-test integration iam_managed_policy --allow-unsupported --docker PLAY RECAP ********************************************************************* testhost : ok=20 changed=6 unreachable=0 failed=0 skipped=0 rescued=0 ignored=0 AWS ACTIONS: ['iam:CreatePolicy', 'iam:CreatePolicyVersion', 'iam:DeletePolicy', 'iam:DeletePolicyVersion', 'iam:GetPolicy', 'iam:GetPolicyVersion', 'iam:ListEntitiesForPolicy', 'iam:ListPolicies', 'iam:ListPolicyVersions', 'iam:SetDefaultPolicyVersion']
* prepare 3.1.0 * dafuq
backport-3: Stabilize ec2_eip module (#936) Backport into stable-3 of #936 with commit id: d0596e3 SUMMARY fixed check_mode issues added integration tests for check_mode / idempotency updated json returned when state = absent for clarity removed json_query references fixes #159 Depends-On: ansible-collections/amazon.aws#672 ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_eip Reviewed-by: Mark Woolley Reviewed-by: Mark Chappell Reviewed-by: Alina Buzachis Reviewed-by: Joseph Torcasso Reviewed-by: Jill R SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION
[PR #952/82ad0843 backport][stable-3] Remove string of iam_managed_policy module docs This is a backport of PR #952 as merged into main (82ad084). SUMMARY Remove "ex nihilo" docs of iam_managed_policy module ISSUE TYPE Docs Pull Request COMPONENT NAME iam_managed_policy Reviewed-by: Mark Chappell <None>
[PR #966/86741fed backport][stable-3] elb_target_group - support target_type alb This is a backport of PR #966 as merged into main (86741fe). SUMMARY Add support for target_type alb and integration tests Update documentation for clarity Fixes #891 ISSUE TYPE Feature Pull Request COMPONENT NAME elb_target_group
#990) [PR #970/56f55fac backport][stable-3] redshift_info - fix invalid import path for botocore exceptions This is a backport of PR #970 as merged into main (56f55fa). Depends-On: #979 SUMMARY Fix invalid import path for botocore exceptions Fixes #968 ISSUE TYPE Bugfix Pull Request COMPONENT NAME redshift_info
) [PR #962/9230c698 backport][stable-3] wafv2_web_acl: prevent exception when element is not a dict This is a backport of PR #962 as merged into main (9230c69). SUMMARY the geo_match_statement statement paremeter country_codes is a list and will fail the current implementation File "/tmp/ansible_community.aws.wafv2_web_acl_payload_8xvwtxvw/ansible_community.aws.wafv2_web_acl_payload.zip/ansible_collections/community/aws/plugins/module_utils/wafv2.py", line 52, in wafv2_snake_dict_to_camel_dict AttributeError: 'str' object has no attribute 'keys' rules: - name: block-germany priority: 0 action: block: {} visibility_config: sampled_requests_enabled: yes cloud_watch_metrics_enabled: yes metric_name: block-germany statement: geo_match_statement: country_codes: - DE ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/module_utils/wafv2.py ADDITIONAL INFORMATION
[PR #977/280d7a2f backport][stable-3] Add backoff logic to elb_application_lb_info This is a backport of PR #977 as merged into main (280d7a2). SUMMARY From time to time rate limiting failures occur on the usage of this module, this PR adds backoff logic to the module to improve its stability. fatal: [127.0.0.1 -> 127.0.0.1]: FAILED! => changed=false boto3_version: 1.20.34 botocore_version: 1.23.34 error: code: Throttling message: Rate exceeded type: Sender msg: 'Failed to list load balancers: An error occurred (Throttling) when calling the DescribeLoadBalancers operation (reached max retries: 4): Rate exceeded' response_metadata: http_headers: content-length: '271' content-type: text/xml date: Thu, 10 Mar 2022 10:34:23 GMT x-amzn-requestid: xxxxx http_status_code: 400 max_attempts_reached: true request_id: xxxxx retry_attempts: 4 ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_application_lb_info ADDITIONAL INFORMATION
[PR #925/87848dcc backport][stable-3] New module for creating Cloudfront header policies… This is a backport of PR #925 as merged into main (87848dc). .. used for response headers SUMMARY New Cloudfront module for CF response headers policies, see https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/adding-response-headers.html This is still a relavily new feature, see https://aws.amazon.com/de/blogs/networking-and-content-delivery/amazon-cloudfront-introduces-response-headers-policies/ ISSUE TYPE New Module Pull Request COMPONENT NAME cloudfront_response_headers_policy.py
… (#1000) [PR #961/e670b348 backport][stable-3] IAM Role Removal Does Not Require Removal of Permission Boundary This is a backport of PR #961 as merged into main (e670b34). SUMMARY Removes unnecessary removal of permission boundary from a role when deleting a role. Unlike inline policies, permission boundaries do not need to be removed from an IAM role before deleting the IAM role. This behavior causes issues when a permission boundary is inherited that prevents removal of the permission boundary. Fixes #959 ISSUE TYPE Bugfix Pull Request COMPONENT NAME iam_role
[PR #840/c67c8907 backport][stable-3] Support changing of launch type This is a backport of PR #840 as merged into main (c67c890). SUMMARY When changing the launch_type parameter for an ecs_taskdefition there was no change reported by the module. This adds a check to see if launch_type in the ecs_taskdefinition has changed. If there is a change detected the module reports back there is not a matching task definition and creates a new one. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ecs_taskdefinition
…module name with missing integration tests. (#986) (#1010) Add a fake integration suite including an aliases file listing every … …module name with missing integration tests. (#986) Prevent CI to be run for whole collection when modules without integration tests are modified Add a fake integration suite including an aliases file listing every module name with missing integration tests. This fake suite is necessary for the new CI ansible-test-splitter behaviour. Namely, if one of the modules (listed in the aliases file) without a test suite is modified, the CI is run for the entire collection since the ansible-test-splitter won't find any target match. This fake integration suite helps handle this situation by avoiding running the CI for the whole collection. Furthermore, since the modules listed in the aliases file are marked as disabled, tests are automatically skipped). Add some of the modules in the aliases files where it makes more sense. SUMMARY ISSUE TYPE Bugfix Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Woolley <[email protected]>
) (#1014) [PR #973/30150139 backport][stable-3] ec2_asg_instance_refresh and ec2_asg_instance_refresh_info modules This is a backport of PR #973 as merged into main (3015013). SUMMARY Reviving original PR that adds Autoscaling instance refresh API support as the author has yet not updated PR based on review feedback. Issue: #135 PR being revived: #795 Fixes #135 ISSUE TYPE New Module Pull Request COMPONENT NAME ec2_asg_instance_refresh ec2_asg_instance_refreshes_info ADDITIONAL INFORMATION More about the feature: https://aws.amazon.com/blogs/compute/introducing-instance-refresh-for-ec2-auto-scaling/ Boto3 documentation: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/autoscaling.html#AutoScaling.Client.start_instance_refresh
Backport elb_target_group_info PRs to stable-3 SUMMARY Backport elb_target_group_info PRs to stable-3 Original PRs: #1001 (backoff) #1015 (fix) ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_target_group_info ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]>
) (#1022) [PR #1016/10137a2a backport][stable-3] Add support for load_balancing_algorithm_type in elb_target_group This is a backport of PR #1016 as merged into main (10137a2). SUMMARY AWS has supported setting the load_balancing.algorithm.type for a little while now allowing you to choose between either round_robin or least_oustanding_requests this PR adds support for setting the new parameter. ISSUE TYPE Feature Pull Request COMPONENT NAME elb_target_group ADDITIONAL INFORMATION https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/elbv2.html#ElasticLoadBalancingv2.Client.modify_target_group_attributes https://aws.amazon.com/about-aws/whats-new/2019/11/application-load-balancer-now-supports-least-outstanding-requests-algorithm-for-load-balancing-requests/
backport Various integration test fixes (#984) SUMMARY Backport #984 into stable-3 c5e4640 Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Alina Buzachis <None>
Backport: Move some shared logic in module utils/sns (#879) SUMMARY Backport Move some shared logic in module utils/sns (#879) to stable-3 ISSUE TYPE Feature Pull Request COMPONENT NAME sns_topic sns sns_topic_info Reviewed-by: Mark Chappell Reviewed-by: Mark Woolley Reviewed-by: Markus Bergholz Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Alina Buzachis <None>
…c default sg (#1025) Backport: elb_application_lb - check_mode support, alb attributes, vpc default sg SUMMARY Backport #894 #963 #971 manually to resolve conflicts. ISSUE TYPE Feature Pull Request COMPONENT NAME elb_application_lb Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None>
[PR #673/58b3c687 backport][stable-3] sns_topic_info new module This is a backport of PR #673 as merged into main (58b3c68). SUMMARY sns_topic_info - new module allowing to get all AWS SNS topics or properties of a specific AWS SNS topic. Fixes #601 Requires #879 ISSUE TYPE New Module Pull Request COMPONENT NAME sns_topic_info Reviewed-by: Mark Woolley <[email protected]>
[PR #562/ce599bdf backport][stable-3] rds_subnet_group: Add tags feature and enable check_mode This is a backport of PR #562 as merged into main (ce599bd). SUMMARY rds_subnet_group: Add tags feature and enable check_mode Fixes: #552 Depends-On: ansible-collections/amazon.aws#553 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_subnet_group Reviewed-by: Mark Woolley <[email protected]>
[PR #1028/fd922064 backport][stable-3] Copy ignore-2.13.txt to ignore-2.14.txt This is a backport of PR #1028 as merged into main (fd92206). SUMMARY Relates to ansible-collections/news-for-maintainers#13 ISSUE TYPE Feature Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None>
Backport: Refactor s3_bucket_notifications to support SNS / SQS (#940) - stable-3 SUMMARY Backport #940 manually to resolve conflict ISSUE TYPE Feature Pull Request COMPONENT NAME s3_bucket_notification ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None>
ec2_asg: backport PRs 960 and 933 SUMMARY ec2_asg: backports PRs #960 and #933 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]>
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…ctions#1039) `ec2_instance` retry on `InsuffienctInstanceCapacity ` SUMMARY Closes ansible-collections#1038 Expands the use of the AWSRetry decorator to include InsuffienctInstanceCapacity errors. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_instance Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
prepare release 3.2.0
ISSUE TYPE
COMPONENT NAME
entire collection