Change social image strings to environment variable (forem#2763)

anonymous-security-public · May 8, 2019 · d730e8c · d730e8c
1 parent d3c929d
commit d730e8c
Show file tree

Hide file tree

Showing 10 changed files with 19 additions and 18 deletions.
diff --git a/Envfile b/Envfile
@@ -11,6 +11,7 @@ enable_defaults! { ENV["RACK_ENV"] != "production" }
 variable :APP_DOMAIN, :String, default: "localhost:3000"
 variable :APP_PROTOCOL, :String, default: "http://"
 variable :COMMUNITY_NAME, :String, default: "DEV(local)"
+variable :MAIN_SOCIAL_IMAGE, :String, default: "https://thepracticaldev.s3.amazonaws.com/i/6hqmcjaxbgbon8ydw93z.png"
 
 # Logo
 variable :LOGO_SVG, :String, default: ""

diff --git a/app/views/articles/index.html.erb b/app/views/articles/index.html.erb
@@ -12,14 +12,14 @@
   <meta property="og:type" content="website" />
   <meta property="og:url" content="https://dev.to<%= request.path %>" />
   <meta property="og:title" content="<%= title_with_timeframe(page_title: community_qualified_name, timeframe: params[:timeframe]) %>" />
-  <meta property="og:image" content="https://thepracticaldev.s3.amazonaws.com/i/g355ol6qsrg0j2mhngz9.png">
+  <meta property="og:image" content="<%= ApplicationConfig["MAIN_SOCIAL_IMAGE"] %>">
   <meta property="og:description" content="Where programmers share ideas and help each other grow." />
   <meta property="og:site_name" content="<%= community_qualified_name %>" />
 
   <meta name="twitter:site" content="@ThePracticalDev">
   <meta name="twitter:title" content="<%= title_with_timeframe(page_title: community_qualified_name, timeframe: params[:timeframe]) %>">
   <meta name="twitter:description" content="Where programmers share ideas, experiences, and help each other grow.">
-  <meta name="twitter:image:src" content="https://thepracticaldev.s3.amazonaws.com/i/g355ol6qsrg0j2mhngz9.png">
+  <meta name="twitter:image:src" content="<%= ApplicationConfig["MAIN_SOCIAL_IMAGE"] %>">
   <meta name="twitter:card" content="summary_large_image">
   <%= auto_discovery_link_tag(:rss, "https://dev.to/feed", title: "#{ApplicationConfig['COMMUNITY_NAME']} RSS Feed") %>
 <% end %>

diff --git a/app/views/articles/search/_meta.html.erb b/app/views/articles/search/_meta.html.erb
@@ -6,12 +6,12 @@
 <meta property="og:type" content="website" />
 <meta property="og:url" content="DEV => Search Results" />
 <meta property="og:title" content="The DEV Community" />
-<meta property="og:image" content="https://thepracticaldev.s3.amazonaws.com/i/g355ol6qsrg0j2mhngz9.png">
+<meta property="og:image" content="<%= ApplicationConfig["MAIN_SOCIAL_IMAGE"] %>">
 <meta property="og:description" content="Where programmers share ideas and help each other grow." />
 <meta property="og:site_name" content="The DEV Community" />
 
 <meta name="twitter:site" content="@ThePracticalDev">
 <meta name="twitter:title" content="DEV => Search Results">
 <meta name="twitter:description" content="Where programmers share ideas, experiences, and help each other grow.">
-<meta name="twitter:image:src" content="https://thepracticaldev.s3.amazonaws.com/i/g355ol6qsrg0j2mhngz9.png">
+<meta name="twitter:image:src" content="<%= ApplicationConfig["MAIN_SOCIAL_IMAGE"] %>">
 <meta name="twitter:card" content="summary_large_image">
diff --git a/app/views/articles/tags/_meta.html.erb b/app/views/articles/tags/_meta.html.erb
@@ -23,7 +23,7 @@
   <meta property="og:image" content="<%= tag_social_preview_url(@tag_model, format: :png) %>">
   <meta name="twitter:image:src" content="<%= tag_social_preview_url(@tag_model, format: :png) %>">
 <% else %>
-  <meta property="og:image" content="https://thepracticaldev.s3.amazonaws.com/i/g355ol6qsrg0j2mhngz9.png">
-  <meta name="twitter:image:src" content="https://thepracticaldev.s3.amazonaws.com/i/g355ol6qsrg0j2mhngz9.png">
+  <meta property="og:image" content="<%= ApplicationConfig["MAIN_SOCIAL_IMAGE"] %>">
+  <meta name="twitter:image:src" content="<%= ApplicationConfig["MAIN_SOCIAL_IMAGE"] %>">
   <meta name="twitter:card" content="summary_large_image">
 <% end %>
diff --git a/app/views/events/show.html.erb b/app/views/events/show.html.erb
@@ -10,7 +10,7 @@
   <% if @event.cover_image.present? %>
     <meta property="og:image" content="<%= @event.cover_image_url %>" />
   <% else %>
-    <meta property="og:image" content="https://thepracticaldev.s3.amazonaws.com/i/g355ol6qsrg0j2mhngz9.png" />
+    <meta property="og:image" content="<%= ApplicationConfig["MAIN_SOCIAL_IMAGE"] %>" />
   <% end %>
   <meta property="og:description" content="<%= truncate(strip_tags(@event.description_html), length: 140) %>" />
   <meta property="og:site_name" content="The Practical Dev" />
@@ -22,7 +22,7 @@
   <% if @event.cover_image.present? %>
     <meta name="twitter:image:src" content="<%= @event.cover_image_url %>">
   <% else %>
-    <meta name="twitter:image:src" content="https://thepracticaldev.s3.amazonaws.com/i/g355ol6qsrg0j2mhngz9.png">
+    <meta name="twitter:image:src" content="<%= ApplicationConfig["MAIN_SOCIAL_IMAGE"] %>">
   <% end %>
 <% end %>
 

diff --git a/app/views/pages/community_moderation.html.erb b/app/views/pages/community_moderation.html.erb
@@ -8,15 +8,15 @@
   <meta property="og:type" content="article" />
   <meta property="og:url" content="https://dev.to/community-moderation" />
   <meta property="og:title" content="Community Moderation Guide for dev.to()" />
-  <meta property="og:image" content="https://thepracticaldev.s3.amazonaws.com/i/g355ol6qsrg0j2mhngz9.png" />
+  <meta property="og:image" content="<%= ApplicationConfig["MAIN_SOCIAL_IMAGE"] %>" />
   <meta property="og:description" content="Things to know!" />
   <meta property="og:site_name" content="The Practical Dev" />
 
   <meta name="twitter:card" content="summary_large_image">
   <meta name="twitter:site" content="@ThePracticalDev">
   <meta name="twitter:title" content="Community Moderation Guide for dev.to()">
   <meta name="twitter:description" content="Things to know!">
-  <meta name="twitter:image:src" content="https://thepracticaldev.s3.amazonaws.com/i/g355ol6qsrg0j2mhngz9.png">
+  <meta name="twitter:image:src" content="<%= ApplicationConfig["MAIN_SOCIAL_IMAGE"] %>">
 <% end %>
 <style>
   img {

diff --git a/app/views/pages/information.html.erb b/app/views/pages/information.html.erb
@@ -8,15 +8,15 @@
   <meta property="og:type" content="article" />
   <meta property="og:url" content="https://dev.to/p/information" />
   <meta property="og:title" content="All information about The Practical Dev" />
-  <meta property="og:image" content="https://thepracticaldev.s3.amazonaws.com/i/g355ol6qsrg0j2mhngz9.png" />
+  <meta property="og:image" content="<%= ApplicationConfig["MAIN_SOCIAL_IMAGE"] %>" />
   <meta property="og:description" content="The DEV Community is great!" />
   <meta property="og:site_name" content="The DEV Community" />
 
   <meta name="twitter:card" content="summary_large_image">
   <meta name="twitter:site" content="@ThePracticalDev">
   <meta name="twitter:title" content="All information about The Practical Dev">
   <meta name="twitter:description" content="The DEV Community is great!">
-  <meta name="twitter:image:src" content="https://thepracticaldev.s3.amazonaws.com/i/g355ol6qsrg0j2mhngz9.png">
+  <meta name="twitter:image:src" content="<%= ApplicationConfig["MAIN_SOCIAL_IMAGE"] %>">
 <% end %>
 
 <style>

diff --git a/app/views/pages/org_info.html.erb b/app/views/pages/org_info.html.erb
@@ -8,15 +8,15 @@
   <meta property="og:type" content="article" />
   <meta property="og:url" content="https://dev.to/organization-info" />
   <meta property="og:title" content="Information about organization accounts on DEV" />
-  <meta property="og:image" content="https://thepracticaldev.s3.amazonaws.com/i/g355ol6qsrg0j2mhngz9.png" />
+  <meta property="og:image" content="<%= ApplicationConfig["MAIN_SOCIAL_IMAGE"] %>" />
   <meta property="og:description" content="The DEV Community is great!" />
   <meta property="og:site_name" content="The DEV Community" />
 
   <meta name="twitter:card" content="summary_large_image">
   <meta name="twitter:site" content="@ThePracticalDev">
   <meta name="twitter:title" content="All information about The Practical Dev">
   <meta name="twitter:description" content="The DEV Community is great!">
-  <meta name="twitter:image:src" content="https://thepracticaldev.s3.amazonaws.com/i/g355ol6qsrg0j2mhngz9.png">
+  <meta name="twitter:image:src" content="<%= ApplicationConfig["MAIN_SOCIAL_IMAGE"] %>">
 <% end %>
 
 <div class="blank-space"></div>

diff --git a/app/views/pages/tag_moderation.html.erb b/app/views/pages/tag_moderation.html.erb
@@ -8,15 +8,15 @@
   <meta property="og:type" content="article" />
   <meta property="og:url" content="https://dev.to/tag-moderation" />
   <meta property="og:title" content="Tag Moderation Guide for dev.to()" />
-  <meta property="og:image" content="https://thepracticaldev.s3.amazonaws.com/i/g355ol6qsrg0j2mhngz9.png" />
+  <meta property="og:image" content="<%= ApplicationConfig["MAIN_SOCIAL_IMAGE"] %>" />
   <meta property="og:description" content="Things to know!" />
   <meta property="og:site_name" content="The Practical Dev" />
 
   <meta name="twitter:card" content="summary_large_image">
   <meta name="twitter:site" content="@ThePracticalDev">
   <meta name="twitter:title" content="Tag Moderation Guide for dev.to()">
   <meta name="twitter:description" content="Things to know!">
-  <meta name="twitter:image:src" content="https://thepracticaldev.s3.amazonaws.com/i/g355ol6qsrg0j2mhngz9.png">
+  <meta name="twitter:image:src" content="<%= ApplicationConfig["MAIN_SOCIAL_IMAGE"] %>">
 <% end %>
 <style>
   img {

diff --git a/app/views/videos/index.html.erb b/app/views/videos/index.html.erb
@@ -8,14 +8,14 @@
   <meta property="og:type" content="website" />
   <meta property="og:url" content="https://dev.to<%= request.path %>" />
   <meta property="og:title" content="<% title "Videos" %>" />
-  <meta property="og:image" content="https://thepracticaldev.s3.amazonaws.com/i/g355ol6qsrg0j2mhngz9.png">
+  <meta property="og:image" content="<%= ApplicationConfig["MAIN_SOCIAL_IMAGE"] %>">
   <meta property="og:description" content="All videos on DEV" />
   <meta property="og:site_name" content="<%= community_qualified_name %>" />
 
   <meta name="twitter:site" content="@ThePracticalDev">
   <meta name="twitter:title" content="<% title "Videos" %>">
   <meta name="twitter:description" content="All videos on DEV">
-  <meta name="twitter:image:src" content="https://thepracticaldev.s3.amazonaws.com/i/g355ol6qsrg0j2mhngz9.png">
+  <meta name="twitter:image:src" content="<%= ApplicationConfig["MAIN_SOCIAL_IMAGE"] %>">
   <meta name="twitter:card" content="summary_large_image">
 <% end %>