Skip to content

Commit

Permalink
Rubocop: regenerate todo and fix RSpec/FilePath (forem#2358)
Browse files Browse the repository at this point in the history
* Regenerate rubocop todo

* Fix RSpec/FilePath
  • Loading branch information
rhymes authored and benhalpern committed Apr 10, 2019
1 parent cd34243 commit b7b5232
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 34 deletions.
3 changes: 3 additions & 0 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -182,5 +182,8 @@ Rails/HasAndBelongsToMany:
Description: 'Prefer has_many :through to has_and_belongs_to_many.'
Enabled: false

Rails/HasManyOrHasOneDependent:
Enabled: false

Rails/SkipsModelValidations:
Enabled: false
59 changes: 25 additions & 34 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -1,32 +1,48 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2019-02-02 16:50:41 +0100 using RuboCop version 0.63.1.
# on 2019-04-10 05:04:16 +0200 using RuboCop version 0.67.2.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

# Offense count: 8
# Offense count: 10
# Configuration parameters: CountComments, ExcludedMethods.
# ExcludedMethods: refine
Metrics/BlockLength:
Max: 69

# Offense count: 18
# Offense count: 21
Metrics/PerceivedComplexity:
Max: 15
Max: 13

# Offense count: 1
# Configuration parameters: CustomTransform, IgnoreMethods.
RSpec/FilePath:
RSpec/AnyInstance:
Exclude:
- 'spec/liquid_tags/raw_tag_spec.rb'
- 'spec/requests/stripe_cancellations_spec.rb'

# Offense count: 20
# Offense count: 145
# Configuration parameters: AggregateFailuresByDefault.
RSpec/MultipleExpectations:
Max: 6

# Offense count: 16
Rails/OutputSafety:
Exclude:
- 'app/controllers/stripe_subscriptions_controller.rb'
- 'app/helpers/application_helper.rb'
- 'app/helpers/comments_helper.rb'
- 'app/labor/markdown_parser.rb'
- 'app/liquid_tags/dev_comment_tag.rb'
- 'app/liquid_tags/github_tag/github_issue_tag.rb'
- 'app/liquid_tags/liquid_tag_base.rb'
- 'app/liquid_tags/tweet_tag.rb'
- 'app/models/comment.rb'
- 'app/models/display_ad.rb'
- 'app/models/message.rb'
- 'app/views/api/v0/articles/show.json.jbuilder'
- 'app/views/articles/feed.rss.builder'

# Offense count: 15
# Cop supports --auto-correct.
# Configuration parameters: AutoCorrect, EnforcedStyle.
Expand All @@ -49,33 +65,8 @@ Style/ClassAndModuleChildren:
- 'app/controllers/notifications/counts_controller.rb'
- 'app/controllers/notifications/reads_controller.rb'

RSpec/AnyInstance:
Exclude:
- 'spec/requests/stripe_cancellations_spec.rb'

# Offense count: 1283
# Offense count: 1754
# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
# URISchemes: http, https
Metrics/LineLength:
Max: 279

Rails/HasManyOrHasOneDependent:
Enabled: false

# Potential security risks
# Offense count: 16
Rails/OutputSafety:
Exclude:
- 'app/controllers/stripe_subscriptions_controller.rb'
- 'app/helpers/application_helper.rb'
- 'app/helpers/comments_helper.rb'
- 'app/labor/markdown_parser.rb'
- 'app/liquid_tags/dev_comment_tag.rb'
- 'app/liquid_tags/github_tag/github_issue_tag.rb'
- 'app/liquid_tags/liquid_tag_base.rb'
- 'app/liquid_tags/tweet_tag.rb'
- 'app/models/comment.rb'
- 'app/models/display_ad.rb'
- 'app/models/message.rb'
- 'app/views/api/v0/articles/show.json.jbuilder'
- 'app/views/articles/feed.rss.builder'
File renamed without changes.

0 comments on commit b7b5232

Please sign in to comment.