Fix non-english characters delete on tags (forem#2579)

anonymous-security-public · Apr 29, 2019 · 5b03403 · 5b03403
1 parent 2ea6acc
commit 5b03403
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/app/lib/acts_as_taggable_on/tag_parser.rb b/app/lib/acts_as_taggable_on/tag_parser.rb
@@ -13,7 +13,7 @@ def clean(string)
       return [] if string.blank?
 
       string.downcase.split(",").map do |t|
-        t.strip.delete(" ").gsub(/[^0-9a-z]/i, "")
+        t.strip.delete(" ").gsub(/[^[:alnum:]]/i, "")
       end
     end
 

diff --git a/spec/lib/acts_as_taggable_on/tag_parser_spec.rb b/spec/lib/acts_as_taggable_on/tag_parser_spec.rb
@@ -25,6 +25,10 @@ def create_tag_parser(tag_arr)
       tags = ["w0rd", "app|3", "&!tes4@#$%^&*"]
       expect(create_tag_parser(tags)).to eq(%w[w0rd app3 tes4])
     end
+    it "allows non-english characters" do
+      tags = %w[Optimización Καλημέρα Français]
+      expect(create_tag_parser(tags)).to eq(%w[optimización καλημέρα français])
+    end
     it "returns nothing if nothing is recieved" do
       expect(create_tag_parser([])).to eq([])
     end