Skip to content

Aniket/logout modal #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

Aniket1026
Copy link

Description

Successfully added the logout Modal which popups when Logout button is clicked asking the user if he wants to logout or not ?

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)
    • The Popup Modal is an additional functionality .
    • The conflicts arrived during has been resolved and they doesn't break the code.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Owner

@anomic30 anomic30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't remove the .env.example file. Add those back again and raise a PR.

@anomic30 anomic30 linked an issue Oct 3, 2022 that may be closed by this pull request
@anomic30
Copy link
Owner

anomic30 commented Oct 3, 2022

Hey, the color of the button text and the font style is not according to the UI. Please fix those.

Current:
image

Required:
image

Copy link
Owner

@anomic30 anomic30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you expose the API keys? It should be kept empty.
Kindly go through our main branch to check the content of the .env.example

@Aniket1026
Copy link
Author

Why did you expose the API keys? It should be kept empty. Kindly go through our main branch to check the content of the .env.example

Yeahh I did it by mistake . I'll remove them

@anomic30
Copy link
Owner

anomic30 commented Oct 3, 2022

Hey, you forgot to remove the API keys from the server/.env.example also.
Also, try to follow the style guidelines.

@Aniket1026
Copy link
Author

Aniket1026 commented Oct 3, 2022

I'm just First timer in hacktoberfest. Sorry for the inconvenience . I've removed the keys from both the files . Also When the popup Appears. I'm not able to make the background a bit transparent . Do tell if i've to make anymore improvements in my PR.

@Aniket1026 Aniket1026 requested a review from anomic30 October 3, 2022 13:59
@anomic30 anomic30 mentioned this pull request Oct 3, 2022
@Aniket1026
Copy link
Author

I've changed the background also for when the popup appears . You can check it for potential mistakes 😅

@anomic30 anomic30 requested a review from Sneakad October 3, 2022 17:56
Copy link
Collaborator

@Sneakad Sneakad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aniket1026 can you please bring the modal in the middle of the display?
image

@Aniket1026
Copy link
Author

Aniket1026 commented Oct 5, 2022

@Sneakad Done . Does it looks fine now ?

@Aniket1026 Aniket1026 requested review from Sneakad and anomic30 and removed request for anomic30 and Sneakad October 5, 2022 18:03
@Aniket1026 Aniket1026 requested review from Sneakad and anomic30 and removed request for anomic30 and Sneakad October 5, 2022 18:03
Copy link
Owner

@anomic30 anomic30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please indent the code as it was before.

<Route path="/app" element={<Main />}>
<Route path="/app/home" element={<Home />} />
<Route path="/app/myFiles" element={<MyFiles />} />
<Route
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make it in one line

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

<Main setLogoutModal={setLogoutModal} logoutModal={logoutModal} />
}
>
<Route
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

import Axios from 'axios';
import Tippy from '@tippyjs/react'
import 'tippy.js/dist/tippy.css'
import React, { useContext, useState } from "react";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove double quotation for all the imports

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Aniket1026 Aniket1026 requested review from anomic30 and removed request for Sneakad October 7, 2022 19:45
@Aniket1026
Copy link
Author

@anomic30 @Sneakad any further updates for me?

@Aniket1026 Aniket1026 requested review from Sneakad and removed request for anomic30 November 1, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popup Modal for Logout
3 participants