-
-
Notifications
You must be signed in to change notification settings - Fork 69
Aniket/logout modal #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't remove the .env.example file. Add those back again and raise a PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you expose the API keys? It should be kept empty.
Kindly go through our main branch to check the content of the .env.example
Yeahh I did it by mistake . I'll remove them |
Hey, you forgot to remove the API keys from the server/.env.example also. |
I'm just First timer in hacktoberfest. Sorry for the inconvenience . I've removed the keys from both the files . Also When the popup Appears. I'm not able to make the background a bit transparent . Do tell if i've to make anymore improvements in my PR. |
…t/logoutModal changes pulled
I've changed the background also for when the popup appears . You can check it for potential mistakes 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Aniket1026 can you please bring the modal in the middle of the display?
@Sneakad Done . Does it looks fine now ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please indent the code as it was before.
<Route path="/app" element={<Main />}> | ||
<Route path="/app/home" element={<Home />} /> | ||
<Route path="/app/myFiles" element={<MyFiles />} /> | ||
<Route |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make it in one line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
<Main setLogoutModal={setLogoutModal} logoutModal={logoutModal} /> | ||
} | ||
> | ||
<Route |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
import Axios from 'axios'; | ||
import Tippy from '@tippyjs/react' | ||
import 'tippy.js/dist/tippy.css' | ||
import React, { useContext, useState } from "react"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove double quotation for all the imports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
…t/logoutModal pulled changes
Description
Successfully added the logout Modal which popups when Logout button is clicked asking the user if he wants to logout or not ?
Fixes # (issue)
Type of change
Checklist: