Skip to content

fix(release): keep @opencode/pty at its own version in release commits - #60115

Open
Hona wants to merge 1 commit into
anomalyco:devfrom
Hona:release-skip-pty
Open

Hona wants to merge 1 commit into
anomalyco:devfrom
Hona:release-skip-pty

Conversation

@Hona

@Hona Hona commented Oct 29, 2026

Copy link
Copy Markdown
Member

tag-release.sh rewrites "version" in every tracked package.json. Since #59695 that includes @opencode/pty (packages/process-daemon/npm), which has its own process-daemon-v* releases, so the v2.2.1 release commit bumped it from 0.3.2 to 2.2.1 (review). Merging that back to dev would fail release-process-daemon.yml's tag validation, because its npm, Cargo and platform versions must match.

-git ls-files -z -- '*package.json' bun.lock | xargs -0 sed -i -E …
+git ls-files -z -- '*package.json' ':!packages/process-daemon/**' bun.lock | xargs -0 sed -i -E …
  • @opencode/pty is the only package.json on dev that doesn't carry the release version, and bun.lock has no entry for it.
  • A test release (2.2.2) with the patched script bumps the other 35 package.json files and leaves @opencode/pty at 0.3.2.
  • release: v2.2.1 #60113 already reverts the 2.2.1 bump. Nothing was published: the npm job only publishes its fixed package list, and the 2.2.1 CLI uses @opencode-ai/pty@0.3.1.

@Hona
Hona requested review from a team and a balanced review from Copilot October 29, 2026 05:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@Hona Hona mentioned this pull request Oct 29, 2026

@opencodejr opencodejr Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I ran the script's version-bump step from the base and from this branch with OPENCODE_VERSION=2.2.2. On the base it bumps @opencode/pty from 0.3.2 to 2.2.2. With this change it stays at 0.3.2, the other 36 files are bumped as before, and the "may only change versions and the changelog" check still passes. The new exclusion only matches packages/process-daemon/npm/package.json.

Public API is unchanged; this only touches the release script.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants