fix(opencode): handle empty session list for attach --dir to prevent segfault#28594
Open
lexlian wants to merge 3 commits into
Open
fix(opencode): handle empty session list for attach --dir to prevent segfault#28594lexlian wants to merge 3 commits into
lexlian wants to merge 3 commits into
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #28214
Type of change
What does this PR do?
opencode attach <url> --dir <PATH>crashes with a Bun segmentation fault when no existing session on the server has a working directory matching<PATH>.Root cause:
validateSession()invalidate-session.tsonly validates when--sessionis provided. When--diris provided without--session, validation is skipped entirely. The TUI then starts with an empty session list filtered by the directory, causing an unhandled rejection that triggers Bun's microtask queue to panic.Fix (two parts):
--diris provided without--session, fetch the session list and throw a clear error if empty.--continueeffect — when no sessions are found for the directory, navigate to home instead of staying on the dummy session route.How did you verify your code works?
test/cli/validate-session.test.ts— all passbun buildScreenshots / recordings
N/A — CLI fix, not a UI change.
Checklist