fix(frame): render diagonal quadrant blocks#34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Render
▚and▞as exact terminal-cell geometry in screenshots, recordings, and catalog frames instead of relying on font glyph metrics.Before / After
Before: diagonal quadrant blocks went through font rendering, where glyph side bearings made the Snake joints look narrower than full terminal quadrants.
After: each glyph is drawn as two exact half-cell rectangles, matching terminal geometry edge to edge.
How
packages/drive/src/frame/index.tsdefines the two quadrant pairs and draws them through the shared renderer-neutral block path.packages/drive/test/frame.test.tslocks down all rectangle coordinates for both glyphs.Scope
This only changes geometric rendering for
▚and▞. Other symbols continue using their existing block geometry or fallback fonts.Testing
bun run test:effect test/frame.test.ts test/recording/export.test.ts(17 passed)bun run typecheckbun run lintgit diff --checkDemo
Deterministic Drive capture using the diagonal Snake glyphs:
Flow