Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps update #4284

Merged
merged 20 commits into from
Feb 18, 2025
Merged

deps update #4284

merged 20 commits into from
Feb 18, 2025

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Jan 29, 2025

Describe your changes

replaces #4212

Couple things left out for various reasons:

  • ledger-transport and ledger-transport-hid have to match ledger-namada-rs
  • rand and rand_core have to match ed25519-consensus and k256 which have not yet been updated
  • rocksdb to be done separately with updated CI pre-compile
  • all wasmer crates - possibly consensus breaking

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@tzemanovic tzemanovic mentioned this pull request Feb 3, 2025
3 tasks
@tzemanovic tzemanovic force-pushed the tomas/deps-update branch 3 times, most recently from 169e47e to c9a74f7 Compare February 7, 2025 14:55
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 58.00000% with 42 lines in your changes missing coverage. Please review.

Project coverage is 74.42%. Comparing base (82c5111) to head (9ba979c).
Report is 50 commits behind head on main.

Files with missing lines Patch % Lines
crates/node/src/lib.rs 0.00% 15 Missing ⚠️
crates/node/src/shell/mod.rs 15.38% 11 Missing ⚠️
crates/apps_lib/src/wallet/mod.rs 0.00% 6 Missing ⚠️
crates/apps_lib/src/config/genesis/transactions.rs 0.00% 2 Missing ⚠️
crates/apps_lib/src/tendermint_node.rs 0.00% 2 Missing ⚠️
crates/sdk/src/args.rs 0.00% 2 Missing ⚠️
crates/wallet/src/pre_genesis.rs 50.00% 2 Missing ⚠️
crates/apps_lib/src/wallet/pre_genesis.rs 75.00% 1 Missing ⚠️
crates/core/src/ethereum_structs.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4284      +/-   ##
==========================================
+ Coverage   74.17%   74.42%   +0.24%     
==========================================
  Files         343      339       -4     
  Lines      110663   110317     -346     
==========================================
+ Hits        82082    82100      +18     
+ Misses      28581    28217     -364     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic tzemanovic marked this pull request as ready for review February 13, 2025 12:06
tzemanovic added a commit that referenced this pull request Feb 13, 2025
@tzemanovic tzemanovic added non-breaking-change backport-libs-0.47 Backport libraries to 0.47 maintenance branch dependencies labels Feb 13, 2025
@tzemanovic tzemanovic requested a review from sug0 February 13, 2025 12:08
@sug0
Copy link
Collaborator

sug0 commented Feb 13, 2025

uhm ci is totally broken. is this expected?

@tzemanovic
Copy link
Member Author

uhm ci is totally broken. is this expected?

ah sry, it's the patricia_tree that needs a newer toolchain - will downgrade it

tzemanovic added a commit that referenced this pull request Feb 14, 2025
@sug0
Copy link
Collaborator

sug0 commented Feb 14, 2025

getrandom is now failing to build in wasm

@tzemanovic
Copy link
Member Author

getrandom is now failing to build in wasm

there are new requirements for it (https://github.com/rust-random/getrandom?tab=readme-ov-file#webassembly-support) - last commit should fix it

tzemanovic added a commit that referenced this pull request Feb 14, 2025
@tzemanovic
Copy link
Member Author

I've added a note in changelog about the new requirements for SDK WASM build

@sug0
Copy link
Collaborator

sug0 commented Feb 14, 2025

the web interface might need to update the build process of the sdk /cc @jurevans

basically, add this var to the environment when building:

RUSTFLAGS='--cfg getrandom_backend="wasm_js"'

EDIT: actually, maybe not, it might already be taken care of by the feature flag we have added to Cargo.toml

@tzemanovic
Copy link
Member Author

the web interface might need to update the build process of the sdk /cc @jurevans

basically, add this var to the environment when building:

RUSTFLAGS='--cfg getrandom_backend="wasm_js"'

EDIT: actually, maybe not, it might already be taken care of by the feature flag we have added to Cargo.toml

Both are needed :/ For the rustflag, you can also add it in .cargo/config.toml which might be better suited for interface:

[target.wasm32-unknown-unknown]
rustflags = ['--cfg', 'getrandom_backend="wasm_js"']

Copy link
Collaborator

@sug0 sug0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. if you don't mind, could you also squash the fixup! commits?

tzemanovic added a commit that referenced this pull request Feb 14, 2025
@yito88
Copy link
Member

yito88 commented Feb 17, 2025

In IBC tests, Gaia couldn't start due to

Error: While parsing config: toml: invalid character at start of key: {`

Toml files were written in JSON. I guess it happened due to updating toml crate.

@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Feb 18, 2025
mergify bot added a commit that referenced this pull request Feb 18, 2025
@mergify mergify bot merged commit 0ba6dc9 into main Feb 18, 2025
24 of 25 checks passed
@mergify mergify bot deleted the tomas/deps-update branch February 18, 2025 10:55
mergify bot pushed a commit that referenced this pull request Feb 18, 2025
(cherry picked from commit 5fb54e6)
@mergify mergify bot mentioned this pull request Feb 18, 2025
3 tasks
mergify bot added a commit that referenced this pull request Feb 18, 2025
tzemanovic added a commit that referenced this pull request Mar 12, 2025
* maint-libs-0.48:
  Changelog: Release libs 0.48.0
  Namada libs 0.48.0
  Make sure to reset masp_index counter to zero whenever new block is encountered.
  Correct the masp_index once it has been found.
  Reduce cloning of state by updating only the Merkle tree when searching for correct ordering.
  Update commitment tree anchors in benchmarks.
  Order transactions in the cache according to the MASP index instead of the block index.
  Assume that Transactions from the indexer are already ordered.
  Compute the transaction order even when needs_witness_map_update capability is disabled.
  Added a changelog entry.
  Factor out the Transaction order search into a separate function.
  Optimize transaction order search.
  Make client try all Transaction permutations.
  Instrumented code with commitment anchor existence checks.
  Changelog: Release libs 0.47.3
  Namada libs 0.47.3
  changelog: add #4403
  wallet: fix build with "migrations" feature
  gov: fix build with "testing" feature on
  PoS: fix build with "testing" feature on
  ci/benches: increase timeout and use bigger machine
  test: sa003
  test+bench: sa002
  test: SA001
  fix to write toml files
  changelog: add #4284
  sdk: fix breaking change in getrandom wasm build
  deps: cargo update
  deps: move all non-workspace deps into workspace and update
  deps: update wasmparser to wasmer matching version
  deps: update toml
  deps: update sysinfo
  deps: update sha2
  deps: update rpassword
  deps: update rlimit
  deps: update reqwest
  deps: update num256
  clippy: reinstate disallow unwrap_or_default
  deps: update itertools
  deps: update byte-unit
  dep: update bech32
  dep: update base64
  update non-breaking deps
  deps: fix crate vulnerabilities
  changelog: add #4371
  add VERSIONING.md
  Modifies `PartialEq` for `Signer`. `Authorization`s account for the signer when compared
  Fixes bugs in `PartialEq` implementations for `SigningTxData` and `Authorization`
  Changelog #4230
  Removes duplicated sections from transactions before signing or dumping
  Custom implementaion of `PartialEq` for `Authorization`
  Update `PartialEq` for `SigningTxData`
  CI: update the Ledger app version to 3.0.1
  Added a changelog entry.
  Print the transaction's chain ID in expert mode.
  client: warn about min ledger app version when using shielded keys
  changelog: add #4358
  wallet: check min ledger app version for shielded key derivation
  Added changelog entry.
  Update hardware genesis files to reflect shielded keys derived using new algorithm.
  changelog
  revert hermes version for CI
  upstream hermes
  test/e2e: fix the test with HW wallet automation
tzemanovic added a commit that referenced this pull request Mar 12, 2025
* maint-libs-0.48:
  Changelog: Release libs 0.48.0
  Namada libs 0.48.0
  Make sure to reset masp_index counter to zero whenever new block is encountered.
  Correct the masp_index once it has been found.
  Reduce cloning of state by updating only the Merkle tree when searching for correct ordering.
  Update commitment tree anchors in benchmarks.
  Order transactions in the cache according to the MASP index instead of the block index.
  Assume that Transactions from the indexer are already ordered.
  Compute the transaction order even when needs_witness_map_update capability is disabled.
  Added a changelog entry.
  Factor out the Transaction order search into a separate function.
  Optimize transaction order search.
  Make client try all Transaction permutations.
  Instrumented code with commitment anchor existence checks.
  Changelog: Release libs 0.47.3
  Namada libs 0.47.3
  changelog: add #4403
  wallet: fix build with "migrations" feature
  gov: fix build with "testing" feature on
  PoS: fix build with "testing" feature on
  ci/benches: increase timeout and use bigger machine
  test: sa003
  test+bench: sa002
  test: SA001
  fix to write toml files
  changelog: add #4284
  sdk: fix breaking change in getrandom wasm build
  deps: cargo update
  deps: move all non-workspace deps into workspace and update
  deps: update wasmparser to wasmer matching version
  deps: update toml
  deps: update sysinfo
  deps: update sha2
  deps: update rpassword
  deps: update rlimit
  deps: update reqwest
  deps: update num256
  clippy: reinstate disallow unwrap_or_default
  deps: update itertools
  deps: update byte-unit
  dep: update bech32
  dep: update base64
  update non-breaking deps
  deps: fix crate vulnerabilities
  changelog: add #4371
  add VERSIONING.md
  Modifies `PartialEq` for `Signer`. `Authorization`s account for the signer when compared
  Fixes bugs in `PartialEq` implementations for `SigningTxData` and `Authorization`
  Changelog #4230
  Removes duplicated sections from transactions before signing or dumping
  Custom implementaion of `PartialEq` for `Authorization`
  Update `PartialEq` for `SigningTxData`
  CI: update the Ledger app version to 3.0.1
  Added a changelog entry.
  Print the transaction's chain ID in expert mode.
  client: warn about min ledger app version when using shielded keys
  changelog: add #4358
  wallet: check min ledger app version for shielded key derivation
  Added changelog entry.
  Update hardware genesis files to reflect shielded keys derived using new algorithm.
  changelog
  revert hermes version for CI
  upstream hermes
  test/e2e: fix the test with HW wallet automation
tzemanovic added a commit that referenced this pull request Mar 14, 2025
Namada libs-v0.48.0 major release.

* tag 'libs-v0.48.0': (153 commits)
  Changelog: Release libs 0.48.0
  Namada libs 0.48.0
  Make sure to reset masp_index counter to zero whenever new block is encountered.
  Correct the masp_index once it has been found.
  Reduce cloning of state by updating only the Merkle tree when searching for correct ordering.
  Update commitment tree anchors in benchmarks.
  Order transactions in the cache according to the MASP index instead of the block index.
  Assume that Transactions from the indexer are already ordered.
  Compute the transaction order even when needs_witness_map_update capability is disabled.
  Added a changelog entry.
  Factor out the Transaction order search into a separate function.
  Optimize transaction order search.
  Make client try all Transaction permutations.
  Instrumented code with commitment anchor existence checks.
  Changelog: Release libs 0.47.3
  Namada libs 0.47.3
  changelog: add #4403
  wallet: fix build with "migrations" feature
  gov: fix build with "testing" feature on
  PoS: fix build with "testing" feature on
  ci/benches: increase timeout and use bigger machine
  test: sa003
  test+bench: sa002
  test: SA001
  fix to write toml files
  changelog: add #4284
  sdk: fix breaking change in getrandom wasm build
  deps: cargo update
  deps: move all non-workspace deps into workspace and update
  deps: update wasmparser to wasmer matching version
  deps: update toml
  deps: update sysinfo
  deps: update sha2
  deps: update rpassword
  deps: update rlimit
  deps: update reqwest
  deps: update num256
  clippy: reinstate disallow unwrap_or_default
  deps: update itertools
  deps: update byte-unit
  dep: update bech32
  dep: update base64
  update non-breaking deps
  deps: fix crate vulnerabilities
  changelog: add #4371
  add VERSIONING.md
  Modifies `PartialEq` for `Signer`. `Authorization`s account for the signer when compared
  Fixes bugs in `PartialEq` implementations for `SigningTxData` and `Authorization`
  Changelog #4230
  Removes duplicated sections from transactions before signing or dumping
  Custom implementaion of `PartialEq` for `Authorization`
  Update `PartialEq` for `SigningTxData`
  CI: update the Ledger app version to 3.0.1
  Added a changelog entry.
  Print the transaction's chain ID in expert mode.
  client: warn about min ledger app version when using shielded keys
  changelog: add #4358
  wallet: check min ledger app version for shielded key derivation
  Added changelog entry.
  Update hardware genesis files to reflect shielded keys derived using new algorithm.
  changelog
  revert hermes version for CI
  upstream hermes
  test/e2e: fix the test with HW wallet automation
  Changelog: Release libs 0.47.2
  Namada libs 0.47.2
  move version detection build script from apps_lib into apps
  keep a separate commit for release changelogs
  apps_lib: output artifacts from build script into OUT_DIR
  tx: build tonic artifacts into OUT_DIR
  changelog: add #4347
  sdk/tx: print tx events if any
  declare internal dev-dependencies via path
  changelog: release Namada libs 0.47.1
  Namada libs 0.47.1
  Revert "Merge pull request #4332 from anoma/murisi/test-vectors-with-chain-ids"
  changelog: add #4283
  PoS: emit token transfer event on claim rewards tx
  Added a changelog entry.
  Print the transaction's chain ID in expert mode.
  Rename test_inverse_conversions to make it clear that it now tests something else.
  Added changelog entry.
  Remove the ability to specify which historical epoch amounts are exchanged to.
  Do not query for the inverse conversion when converting to the latest epoch.
  Added changelog entry.
  Update inverse conversion test.
  Now parameterize query_allowed_conversion with the target epoch.
  fixup! deps: use internal crates defined in workspace
  deps: update non-lib crates Cargo.toml to use workspace defs
  config/release: allow to publish released crates
  deps: fix ignored and rm unused default-features flags
  deps: use internal crates defined in workspace
  specify all internal lib crates in workspace
  deps: rm unused borsh-ext
  fixup! changelog: add #4307
  fixup! wallet: change the derivation path for modified ZIP32
  wallet: update the rustdoc warning about modified ZIP32
  changelog: add #4307
  wallet: change the derivation path for modified ZIP32
  Added a changelog entry.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-libs-0.47 Backport libraries to 0.47 maintenance branch dependencies merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass non-breaking-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants