Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message on failed fee payment #4271

Merged
merged 5 commits into from
Jan 27, 2025
Merged

Conversation

grarco
Copy link
Collaborator

@grarco grarco commented Jan 23, 2025

Describe your changes

Closes #4262.

This PR tries to improve the error message we emit in case of a failed masp fee payment by better explaining the logic applied by the protocol

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@grarco grarco marked this pull request as ready for review January 23, 2025 20:50
@grarco grarco requested a review from brentstone January 23, 2025 20:59
@grarco grarco closed this Jan 23, 2025
@grarco grarco reopened this Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 78.94737% with 8 lines in your changes missing coverage. Please review.

Project coverage is 74.02%. Comparing base (80223b3) to head (25d2e92).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
crates/node/src/protocol.rs 76.47% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4271   +/-   ##
=======================================
  Coverage   74.02%   74.02%           
=======================================
  Files         345      345           
  Lines      109920   109943   +23     
=======================================
+ Hits        81367    81390   +23     
  Misses      28553    28553           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Jan 27, 2025
mergify bot added a commit that referenced this pull request Jan 27, 2025
@mergify mergify bot merged commit fb72e57 into main Jan 27, 2025
34 of 44 checks passed
@mergify mergify bot deleted the grarco/masp-fee-error-msg branch January 27, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass non-breaking-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve fee error message
2 participants