Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: add app version to ABCI info query response #4259

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tzemanovic
Copy link
Member

Describe your changes

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@tzemanovic tzemanovic marked this pull request as ready for review January 21, 2025 13:29
@tzemanovic tzemanovic requested a review from brentstone January 21, 2025 13:29
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.32%. Comparing base (9c8bb71) to head (120f7ca).
Report is 43 commits behind head on main.

Files with missing lines Patch % Lines
crates/node/src/shell/mod.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4259      +/-   ##
==========================================
+ Coverage   74.05%   74.32%   +0.26%     
==========================================
  Files         345      345              
  Lines      109782   112097    +2315     
==========================================
+ Hits        81303    83320    +2017     
- Misses      28479    28777     +298     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic tzemanovic force-pushed the tomas/abci-info-version branch from 68d9073 to 120f7ca Compare January 23, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant