Extra tracing during discovery of Xcom devices

ankohanse · Jan 7, 2025 · cd22ba0 · cd22ba0
1 parent 1ea2dd8
commit cd22ba0
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/pyproject.toml b/pyproject.toml
@@ -1,6 +1,6 @@
 [project]
 name = "aioxcom"
-version = "1.7.0"
+version = "1.7.1"
 authors = [
   { name="Anko Hanse", email="[email protected]" },
 ]

diff --git a/src/aioxcom/xcom_discover.py b/src/aioxcom/xcom_discover.py
@@ -59,6 +59,8 @@ async def discoverDevices(self, getExtendedInfo = False) -> list[XcomDiscoveredD
 
         for family in XcomDeviceFamilies.getList():
 
+            _LOGGER.info(f"trying family {family.id} ({family.model})")
+
             # Get value for the specific discovery nr, or otherwise the first info nr or first param nr
             nr = family.nrDiscover or family.nrInfosStart or family.nrParamsStart or None
             if not nr:
@@ -75,6 +77,7 @@ async def discoverDevices(self, getExtendedInfo = False) -> list[XcomDiscoveredD
                 try:
                     param = self._dataset.getByNr(nr, family.idForNr)
 
+                    _LOGGER.info(f"trying device {device_code} on {device_addr} for nr {nr}")
                     value = await self._api.requestValue(param, device_addr)
                     if value is not None:
                         _LOGGER.info(f"Found device {device_code} via {nr}:{device_addr}")
@@ -85,8 +88,11 @@ async def discoverDevices(self, getExtendedInfo = False) -> list[XcomDiscoveredD
 
                         devices.append(device)
 
+                    else:
+                        _LOGGER.info(f"No device {device_code}; no value returned from Xcom client: {e}")
+
                 except Exception as e:
-                    _LOGGER.debug(f"No device {device_code}; no test value returned from Xcom client: {e}")
+                    _LOGGER.info(f"No device {device_code}; no test value returned from Xcom client: {e}")
 
                     # Do not test further device addresses in this family
                     break
@@ -102,6 +108,7 @@ async def getExtendedDeviceInfo(self, device: XcomDiscoveredDevice) -> XcomDisco
         # ID SID
         # ID FID msb/lsb
         try:
+            _LOGGER.info(f"Try get extended device info for device {device.code})")
             family = XcomDeviceFamilies.getById(device.family_id)
 
             id_type    = await self._requestValueByName("ID type",     family.id, device.addr)
@@ -117,8 +124,10 @@ async def getExtendedDeviceInfo(self, device: XcomDiscoveredDevice) -> XcomDisco
             device.sw_version   = self._decodeIdSW(id_sw_msb, id_sw_lsb)
             device.fid          = self._decodeFID(id_fid_msb, id_fid_lsb)
 
+            _LOGGER.info(f"Found extended device info: model: {device.device_model}, hw_version: {device.hw_version}, sw_version: {device.sw_version}, fid: {device.fid})")
+
         except Exception as e:
-            _LOGGER.debug(f"Exception in getExtendedDeviceInfo: {e}")
+            _LOGGER.info(f"Exception in getExtendedDeviceInfo: {e}")
 
         return device