Obsolete GlobalConfiguration #616
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #600 .
So it can be more easily removed in v5.
Thread.CurrentThread.CurrentUICulture
as backing valueThread.CurrentThread.CurrentUICulture
directlyThis is kind of a breaking change. Before it would initialize to
CurrentUICulture
upon first static access toGlobalConfiguration
and that value would no longer match per-thread - but rather be globally static across threads. With this PR, it would instead match .NET's per-thread setup - which one could argue is a bug or a feature that we didn't - but since GlobalConfiguration was introduced in v4 in December and I don't think many/anyone relies on this initialize once behavior, I vote to take this in now.