feat(chromium): download the chromium binary based on a major version #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: Do not merge yet. I think my test isn't quite there yet. |
cnishina
force-pushed
the
chromium
branch
2 times, most recently
from
0b23461 to
7f0cf4b
Compare
cnishina
changed the title
heathkit
suggested changes
Apr 26, 2019
| const configFilePath = path.resolve(this.outDir, this.configFileName); | ||
| return getBinaryPathFromConfig(configFilePath, version); | ||
| } catch (_) { | ||
| return null; |
There was a problem hiding this comment.
What does it mean if there's an exception here? Maybe at least log an error?
There was a problem hiding this comment.
That's probably a good idea. This is a pattern used for all providers so I'll create a new bug to work on this.
heathkit
approved these changes
Jun 5, 2019
Experimental feature to download the chromium browser based on the ChromeDriver version. This might be help to prevent browser / browser driver mismatch when downloading ChromeDriver. In the new scenario, you could download ChromeDriver 73.x.x.x and Chromium 73.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental feature to download the chromium browser based on the
ChromeDriver version. This might be help to prevent browser / browser
driver mismatch when downloading ChromeDriver. In the new scenario, you
could download ChromeDriver 73.x.x.x and Chromium 73.