This repository was archived by the owner on Jul 29, 2024. It is now read-only.
chore(typescript): driverProviders converted to typescript #3142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis errors are legitimate. |
| @@ -1 +1,11 @@ | |||
| declare var browser: any; | |||
|
|
|||
| declare class WebDriver { | |||
There was a problem hiding this comment.
I'm in favor of everything that's required from WebDriver being put in a namespace.
There was a problem hiding this comment.
Yup, after seeing your pr... I am going to change mine to match.
cnishina
force-pushed
the
pr_TSallTheThings
branch
from
41a1992 to
ab14597
Compare
cnishina
force-pushed
the
pr_TSallTheThings
branch
from
ab14597 to
f88523c
Compare
cnishina
force-pushed
the
pr_TSallTheThings
branch
from
f88523c to
818b46b
Compare
Closed
|
Looks good! Merge it. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.