This repository was archived by the owner on Jul 29, 2024. It is now read-only.
chore(typescript): converting task files to typescript #2948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param {object} task Task that is being reported. | ||
| * @param {number} pid PID of process running the task. | ||
| */ | ||
| constructor(task: any, pid: number) { |
There was a problem hiding this comment.
you can declare the property here as well, with private task: any - now you don't need to declare it above, or assign the value below
|
LG for typescript |
cnishina
force-pushed
the
typescript
branch
2 times, most recently
from
c5c36c1 to
ece9c02
Compare
|
Let's change the commit name to |
| @@ -0,0 +1,159 @@ | |||
| import ConfigParser, {Config} from './configParser'; | |||
There was a problem hiding this comment.
Should ConfigParser be in the{}?
There was a problem hiding this comment.
Or is this the default thing working as intended?
There was a problem hiding this comment.
The class ConfigParser is labeled as the default and does not require {}.
|
Looks good other than a couple questions. |
|
Reference feature request: #1203 |
cnishina
changed the title
|
Closed with commit 608104b |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.