Basic Issue List Implementation with localStorage caching #49
Conversation
|
Very minor comment: is there a reason localStorage is preferred over IDB here? localForage offers a ~similar async alternative to localStorage using IDB as backing storage and falls back to LS otherwise. Feel free to ignore :) |
|
@addyosmani thanks for taking a look. I wanted to get a rudimentary caching implementation here just to get some basic caching going. IDB should definitely be the store, and it will be treated as the source of truth with some kind of synchronization mechanism. The store will be more structured than key/value, so localForage probably wouldn't be the best fit. @robwormald has started an IndexedDB implementation based on rxjs at ngrx/db that hopefully can be used here, but I'm not sure what shape it's in :). |
|
Pushed updated PR, added some todos, added some tests, made the github service get the auth token itself instead of having it passed in. |
| this.repos | ||
| .map((repos:Repo[]) => repos[0]) | ||
| .take(1) | ||
| .subscribe(repo => this.repoSelection.next(repo)); |
There was a problem hiding this comment.
I'd bet that internal Subject logic references this at some point, which would cause an unbounded call to fail.
There was a problem hiding this comment.
Wait, no you're right, I was thinking of .next(), but it's an observer, it should be fine.
|
K thx |
No description provided.