build: update dependency aspect_rules_esbuild to v0.26.0#3666
Open
alan-agius4 wants to merge 2 commits into
Open
build: update dependency aspect_rules_esbuild to v0.26.0#3666alan-agius4 wants to merge 2 commits into
alan-agius4 wants to merge 2 commits into
Conversation
See associated pull request for more information. Closes angular#3665 as a pr takeover
angular-robot
Bot
added
the
area: build & ci
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the aspect_rules_esbuild dependency to version 0.26.0 across multiple MODULE.bazel and MODULE.bazel.lock files. Additionally, it introduces a _filter_runfiles rule in bazel/spec-bundling/index.bzl to maintain consistent runfile behavior following upstream changes in rules_esbuild. The reviewer suggested using pop instead of get for the tags attribute to prevent leaking implementation details to the internal esbuild target.
…ndle Wraps the esbuild target created by the `spec_bundle` macro with a custom rule that removes runfiles originating from `deps` and `srcs`. This prevents duplicate spec execution by ensuring downstream targets like `jasmine_test` only receive the bundle's output files in their runfiles tree. Retains the runfiles aggregation behavior as before: alan-agius4/rules_esbuild@e088dc3
alan-agius4
force-pushed
the
pr-takeover-3665
branch
3 times, most recently
from
1db4192 to
45df805
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See associated pull request for more information.
Closes #3665 as a pr takeover