refactor(aria/toolbar): large rework of toolbar internals #32236
+2,638
−1,371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wagnermaciel
commented
Nov 2, 2025
wagnermaciel
commented
- make ListItem.element() optional
- rework toolbar internals
- dev-app demo changes
wagnermaciel
requested review from
andrewseguin
and removed request for
a team
wagnermaciel
added
the
dev-app preview
wagnermaciel
force-pushed
the
ng-toolbar
branch
from
1de694b to
277acd4
Compare
|
Deployed dev-app for 164af77 to: https://ng-dev-previews-comp--pr-angular-components-32236-dev-okl0mpql.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
wagnermaciel
force-pushed
the
ng-toolbar
branch
3 times, most recently
from
d604654 to
8a6edc6
Compare
ok7sai
approved these changes
Nov 3, 2025
wagnermaciel
force-pushed
the
ng-toolbar
branch
from
8a6edc6 to
ec200a6
Compare
wagnermaciel
added
action: merge
wagnermaciel
force-pushed
the
ng-toolbar
branch
from
ec200a6 to
89a45de
Compare
wagnermaciel
force-pushed
the
ng-toolbar
branch
3 times, most recently
from
584108d to
c602270
Compare
wagnermaciel
force-pushed
the
ng-toolbar
branch
from
c602270 to
164af77
Compare
ok7sai
approved these changes
Nov 4, 2025
wagnermaciel
added a commit
that referenced
this pull request
Nov 4, 2025
* refactor(multiple): make ListItem.element() optional * refactor(aria/toolbar): large rework of toolbar internals * refactor(aria/toolbar): dev-app demo changes (cherry picked from commit ccd0e07)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.