Skip to content

fix(material/chips): remove extra span for aria-description #31609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2025

Conversation

adolgachev
Copy link
Contributor

@adolgachev adolgachev commented Jul 29, 2025

FIxes b/351897224 where the extra spans just used for aria-describedby cause the linear navigation to read them as members of an extra group and confuses the narration for the chipset group.

@adolgachev adolgachev changed the title Chips group fix(material/chips): remove extra span for aria-description Aug 5, 2025
@adolgachev adolgachev added Accessibility This issue is related to accessibility (a11y) target: minor This PR is targeted for the next minor release dev-app preview When applied, previews of the dev-app are deployed to Firebase action: global presubmit The PR is in need of a google3 global presubmit labels Aug 5, 2025
Copy link

github-actions bot commented Aug 5, 2025

Deployed dev-app for 28743bc to: https://ng-dev-previews-comp--pr-angular-components-31609-dev-fa3fqymj.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@adolgachev adolgachev added the action: review The PR is still awaiting reviews from at least one requested reviewer label Aug 6, 2025
@adolgachev adolgachev marked this pull request as ready for review August 6, 2025 16:35
@adolgachev adolgachev requested a review from a team as a code owner August 6, 2025 16:35
@adolgachev adolgachev requested review from crisbeto and ok7sai and removed request for a team August 6, 2025 16:35
@adolgachev adolgachev removed the action: global presubmit The PR is in need of a google3 global presubmit label Aug 6, 2025
@adolgachev adolgachev requested review from mmalerba and andrewseguin and removed request for ok7sai and crisbeto August 6, 2025 17:11
@adolgachev adolgachev added the docs: preview When applied, a preview of the documentation site is deployed to Firebase label Aug 6, 2025
Copy link

github-actions bot commented Aug 6, 2025

Deployed docs-preview for 28743bc to: https://ng-dev-previews-comp--pr-angular-components-31609-docs-1im45b7g.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Aug 7, 2025
@adolgachev adolgachev removed the request for review from mmalerba August 7, 2025 17:29
@adolgachev adolgachev merged commit 8da079d into angular:main Aug 7, 2025
32 checks passed
@adolgachev adolgachev deleted the chips-group branch August 7, 2025 17:41
demanr pushed a commit to demanr/components that referenced this pull request Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker action: review The PR is still awaiting reviews from at least one requested reviewer area: material/chips dev-app preview When applied, previews of the dev-app are deployed to Firebase docs: preview When applied, a preview of the documentation site is deployed to Firebase target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants