fix(material/list): fix selection-list staying in tab order when disabled#25735
Merged
zarend merged 1 commit intoangular:mainfrom Oct 12, 2022
Merged
fix(material/list): fix selection-list staying in tab order when disabled#25735zarend merged 1 commit intoangular:mainfrom
zarend merged 1 commit intoangular:mainfrom
Conversation
zarend
added
Accessibility
zarend
requested review from
andrewseguin,
crisbeto,
devversion and
mmalerba
as code owners
zarend
force-pushed
the
disabled-list
branch
2 times, most recently
from
55edfbd to
39a2901
Compare
mmalerba
reviewed
Oct 5, 2022
zarend
force-pushed
the
disabled-list
branch
3 times, most recently
from
09b26ab to
b8baf4d
Compare
Contributor
Author
|
responded to comments, and this is ready for review again 👀 |
…bled Remove list options from the tab order when the entire slection list is disabled. Fix accessibility issue where end user can tab to a disabled selection list. ``` <mat-selection-list disabled> <mat-list-option>A</mat-list-option> <!-- ^ should have tabindex="-1" since entire list is disabled --> </mat-selection-list> ``` Approach is to consider a disabled mat-selection-list with a mat-list-option having `tabindex="0"` an invalid state. When disabled Input on the seleciton list is set to true, set tabindex to -1 on every list option. fixes angular#25730
mmalerba
approved these changes
Oct 11, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove list options from the tab order when the entire slection list is disabled. Fix accessibility issue where end user can tab to a disabled selection list.
Approach is to consider a disabled mat-selection-list with a mat-list-option having
tabindex="0"an invalid state. When disabled Input on the seleciton list is set to true, set tabindex to -1 on every list option.