fix(cdk/overlay): scroll blocking sometimes clipping content #25204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
|
This ended up causing some screenshot difference internally. Some were expected, but there were a handful that need more debugging. |
josephperrott
requested review from
amysorto and
mmalerba
and removed request for
a team
Fixes that under some circumstances the `cdk-global-scrollblock` class was causing the body content to be clipped in the background. Fixes angular#15051.
crisbeto
force-pushed
the
15051/block-scroll-overflow
branch
from
1dff9dc to
093e778
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that under some circumstances the
cdk-global-scrollblockclass was causing the body content to be clipped in the background.Fixes #15051.